1518422 - Most panel footer buttons don't have a focus ring on Linux and Mac

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1518422 - Implement focus ring for panel footer buttons across platforms. r=ntim

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/922a9d4b4b49
Implement focus ring for panel footer buttons across platforms. r=ntim

Comment 3

[Tim Nguyen :ntim]

With the current patch, it seems like macOS would have two different focusrings ? -moz-mac-focusring for .popup-notification-button and the Windows/Linux outline for the other footers.

Is this intentional ?

Comment 4

[Dão Gottwald [:dao]]

It was intentional as it's not clear to me how -moz-mac-focusring would work when the button is blue, but I'm open to changing this in a followup. I don't think it matters much on Mac anyway since users need to enable full keyboard access for this to be used at all.

Comment 5

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #4)

It was intentional as it's not clear to me how -moz-mac-focusring would work when the button is blue, but I'm open to changing this in a followup.

-moz-mac-focusring is not always blue, but either way, if we don't want the .popup-notification-button -moz-mac-focusring, then that rule should probably get removed to get a consistent focusring ?

https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/toolkit/themes/osx/global/notification.css#11-14

Comment 6

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen :ntim from comment #5)

(In reply to Dão Gottwald [::dao] from comment #4)

It was intentional as it's not clear to me how -moz-mac-focusring would work when the button is blue, but I'm open to changing this in a followup.

-moz-mac-focusring is not always blue,

I wasn't asserting that it's always blue.

but either way, if we don't want the .popup-notification-button -moz-mac-focusring, then that rule should probably get removed to get a consistent focusring ?

https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/toolkit/themes/osx/global/notification.css#11-14

Right.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/922a9d4b4b49

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift? It grafts cleanly.

Comment 9

[Dão Gottwald [:dao]]

Since this isn't a regression and practically only Linux ia affected, I think this can just ride the 66 train.