1518442 - Implement Event-based form participation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[tkent]

The HTML specification introduces 'formdata' event.

Specification PR: https://github.com/whatwg/html/pull/4239
WPT PR: https://github.com/web-platform-tests/wpt/pull/14637

Note: Chrome already implemented it behind the experimental flag.

Comment 1

[Marcos Caceres [:marcosc]]

Before working on this, I wanted to confirm that there is not already a "constructing entry list" flag and an "entry list" (or akin concept/definitions/declarations) in our implementation of HTMLFormElement. HTMLFormElement.cpp is a rather complex/large beast, so I'm wondering who might be a good DOM Peer to work with on it? I doubt there is, but don't want to dive in without a plan.

Some of the basic changes that needed are here:
https://whatpr.org/html/4239/edc1e95...ee10279/form-control-infrastructure.html#constructing-form-data-set

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

baku has been dealing with form submission quite a bit :)

Comment 3

[John Dai[:jdai]]

It's part of form participation API[1] which allows arbitrary objects can participate in form submission. Since baku unassigned bug 1519329, I'll contine working this bug.

[1] https://docs.google.com/document/d/1JO8puctCSpW-ZYGU8lF-h4FWRIDQNDVexzHoOQ2iQmY

Comment 4

[John Dai[:jdai]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=263180749&revision=53734d03158b20631a936d7b6eeb7490f106cb60
It remains some test failures need to fix.

Comment 5

[John Dai[:jdai]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=263903787&revision=6a60a8cc21d40e981682fc5734b56f6c559fa62d

Comment 6

[John Dai[:jdai]]

Attachment: Bug 1518442 - Part 1: Implement FormDataEvent interface;

Comment 7

[John Dai[:jdai]]

Attachment: Bug 1518442 - Part 2: Implement Event-based form participation;

https://whatpr.org/html/4239/edc1e95...ee10279/form-control-infrastructure.html#constructing-the-form-data-set

Comment 8

[John Dai[:jdai]]

Attachment: Bug 1518442 - Part 3: Add dom.formdata.event.enabled preference for Event-based form participation;

Comment 9

[John Dai[:jdai]]

Attachment: Bug 1518442 - Part 4: Fix wpt test for Event-based form participation;

Comment 12

[John Dai[:jdai]]

Attachment: Bug 1518442 - Part 5: Add a mochitest for pref-off form data event attribute;

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7a459689227
Part 1: Implement FormDataEvent interface; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/c8fbe42eba38
Part 2: Implement Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/65f7059b0080
Part 3: Add dom.formdata.event.enabled preference for Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/1df8f544b3b7
Part 4: Fix wpt test for Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/a092042068ab
Part 5: Add a mochitest for pref-off form data event attribute; r=smaug,edgar

Comment 14

[John Dai[:jdai]]

Intent-to-ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/-VDYiEAWjw4

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74c27d7d13c5
Part 6: Fix idlharness.https.html wpt test for Event-based form participation; r=jdai

Comment 16

[John Dai[:jdai]]

Please help me back-out the patches because I miss setting default pref-on for part 6. The part 6 wpt tests will fail in beta and release channel.

Comment 17

[Cosmin Sabou [:CosminS]]

Backout link: https://hg.mozilla.org/integration/autoland/rev/dc2ad71ea900f28da89deaf160e658a6d06b3bee

Comment 18

[John Dai[:jdai]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9a52d22477601900f5527bf1c4657ee5594d32

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f280db1076a4
Part 1: Implement FormDataEvent interface; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/1ac7b20bb1d8
Part 2: Implement Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/1f3d36108982
Part 3: Add dom.formdata.event.enabled preference for Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/b1b08f66996c
Part 4: Fix wpt test for Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/9143aef9bd5e
Part 5: Add a mochitest for pref-off form data event attribute; r=smaug,edgar

Comment 20

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18910 for changes under testing/web-platform/tests

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 22

[Josh Matthews [:jdm]]

This added a ini file to the web-platform-tests tests directory instead of the metadata directory: https://github.com/web-platform-tests/wpt/pull/18910

Comment 23

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e7a459689227
https://hg.mozilla.org/mozilla-central/rev/c8fbe42eba38
https://hg.mozilla.org/mozilla-central/rev/65f7059b0080
https://hg.mozilla.org/mozilla-central/rev/1df8f544b3b7
https://hg.mozilla.org/mozilla-central/rev/a092042068ab
https://hg.mozilla.org/mozilla-central/rev/74c27d7d13c5

Comment 24

[Narcis Beleuzu [:NarcisB]]

Backout link: https://hg.mozilla.org/integration/autoland/rev/85e63f698d477fb85fe29d9c94d73961b67a7274

Comment 25

[John Dai[:jdai]]

(In reply to Josh Matthews [:jdm] from comment #22)

This added a ini file to the web-platform-tests tests directory instead of the metadata directory: https://github.com/web-platform-tests/wpt/pull/18910

I also found this mistake, I already request backout.

Comment 26

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 27

[John Dai[:jdai]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=265662967&revision=c309b2c8e435450603985cb6848c8d8773084b87

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc978c5a71a6
Part 1: Implement FormDataEvent interface; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/220138300dd8
Part 2: Implement Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/975942e56797
Part 3: Add dom.formdata.event.enabled preference for Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/8a0b9824539d
Part 4: Fix wpt test for Event-based form participation; r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/e51f7562204d
Part 5: Add a mochitest for pref-off form data event attribute; r=smaug,edgar

Comment 29

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bc978c5a71a6
https://hg.mozilla.org/mozilla-central/rev/220138300dd8
https://hg.mozilla.org/mozilla-central/rev/975942e56797
https://hg.mozilla.org/mozilla-central/rev/8a0b9824539d
https://hg.mozilla.org/mozilla-central/rev/e51f7562204d

Comment 30

[Chris Mills [:cmills]]

I've written docs for this feature; see https://github.com/mdn/sprints/issues/2273#issuecomment-555207411 for the full details.

Please let me know if you think this needs anything else. Thanks!