Closed Bug 1518469 Opened 4 years ago Closed 3 years ago

[remote-dbg-next] Enable new about:debugging on Nightly

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox68 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- verified

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(2 files)

Bug 1518469 - Enable new about:debugging by default;r=ladybenko
47 bytes, text/x-phabricator-request
Details | Review
Bug 1518469 - Redirect old about:debugging routes to This Firefox;r=ladybenko
47 bytes, text/x-phabricator-request
Details | Review

This bug should cover:

  • disabling WebIDE on Nightly
  • disabling the connect page on Nightly
  • redirecting about:debugging to the new UI rather than the old one
Blocks: remote-debugging-ng-m2
No longer blocks: remote-debugging-ng
Priority: -- → P2

This will be tackled in 68 cycle when we are close to shipping.

Priority: P2 → P3

Let's start by enabling the new about:debugging by default in order to get feedback.

Harald pointed out two issues that occur when you have the new about:debugging enabled by default.

  • the menu entry in Tools > Web Developer > Service Workers no longer works
  • the shortcut "Debug addons" in about:addons (located in the "cog" menu button) no longer works

They should be fixed here when we enable the about:debugging-new by default.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [remote-debugging-reserve]
Blocks: 1539461

Disabling WebIDE will be handled in Bug 1539451

Depends on D25061
Two motivations to support the old routes:

  • we have some links inside Firefox (application panel, about:addons, Developer Menu) that link to about:debugging. With this fix we avoid updating the links with code that depends on the value of the preference. We will fully update the links once the old aboutdebugging codebase is removed.
  • there are some external pages that refer to about:debugging#workers or about:debugging#addons (did a quick google search). not a lot of them but this will also allow to keep supporting them
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4039a7cad5d8
Enable new about:debugging by default;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/97f6ade10460
Redirect old about:debugging routes to This Firefox;r=ladybenko

https://hg.mozilla.org/mozilla-central/rev/4039a7cad5d8
https://hg.mozilla.org/mozilla-central/rev/97f6ade10460

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Verified as fixed on Firefox Nightly 68.0a1 (2019-05-14) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
status-firefox68: fixed → verified
You need to log in before you can comment on or make changes to this bug.