Closed Bug 1518543 Opened 8 months ago Closed 7 months ago

Fix Android unit tests on cedar

Categories

(Firefox :: Search, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

Attachments

(1 file)

bug 1492475 introduced a large amount of changes, but getting an Android build done locally took too much time to understand why Services.search wasn't resolved properly on Android. Does it need a clobber? Probably not, but time needs to be spent here to resolve this. However, this can continue without blocking other work.

We obviously won't merge cedar into m-c when the Search Service doesn't work on Android.

Attachment #9037309 - Attachment description: Bug 1518543 - Since we already alias nsIBrowserSearchService to nsISearchService in the IDL, we don't need the branching logic in Services.jsm for Android anymore. r?florian! → Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r?florian!

Florian, I re-requested review, because I changed direction substantially... the approach I've taken in the new patch is to fix up the Android Search Service shim. I explained things further in the commit message.

n-i, Florian, because I'm not sure whether the Phabricator flagging actually works.

Flags: needinfo?(florian)

(In reply to Mike de Boer [:mikedeboer] from comment #5)

n-i, Florian, because I'm not sure whether the Phabricator flagging actually works.

I have no idea what "the Phabricator flagging" means in this context, so I guess that means it didn't do what you wanted.

Flags: needinfo?(florian)
https://hg.mozilla.org/projects/cedar/rev/fd177a7994b250605df4b98740bdd257373e21e5
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.