1518543 - Fix Android unit tests on cedar

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Mike de Boer [:mikedeboer]]

bug 1492475 introduced a large amount of changes, but getting an Android build done locally took too much time to understand why Services.search wasn't resolved properly on Android. Does it need a clobber? Probably not, but time needs to be spent here to resolve this. However, this can continue without blocking other work.

We obviously won't merge cedar into m-c when the Search Service doesn't work on Android.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r?florian!

Comment 2

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5b415092fccb64457511e6d8a3029780263cb5c

Comment 3

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3133d71a0f9b561b495445125b231f9921b36286

Comment 4

[Mike de Boer [:mikedeboer]]

Florian, I re-requested review, because I changed direction substantially... the approach I've taken in the new patch is to fix up the Android Search Service shim. I explained things further in the commit message.

Comment 5

[Mike de Boer [:mikedeboer]]

n-i, Florian, because I'm not sure whether the Phabricator flagging actually works.

Comment 6

[Florian Quèze [:florian]]

(In reply to Mike de Boer [:mikedeboer] from comment #5)

n-i, Florian, because I'm not sure whether the Phabricator flagging actually works.

I have no idea what "the Phabricator flagging" means in this context, so I guess that means it didn't do what you wanted.

Comment 7

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/projects/cedar/rev/fd177a7994b250605df4b98740bdd257373e21e5
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian