1518544 - Bump _WIN32_WINNT to 0x601 for mingw-clang?

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

The comment for mingw-clang says it's 0x600 to match old-configure.in (https://searchfox.org/mozilla-central/source/taskcluster/scripts/misc/build-clang-trunk-mingw.sh#43) but we actually use 601 (https://searchfox.org/mozilla-central/source/old-configure.in#136)

Should we update the mingw version?

I tried it and it seemed to build fine at least: https://treeherder.mozilla.org/#/jobs?repo=try&revision=44ec3148dd5f6bb3f59720eb675f65e17b015214

Comment 1

[Jacek Caban]

Since we set it in configure anyway, default toolchain define doesn't really matter. But sure, it wouldn't hurt to change.

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1518544 - Bump the default value of _WIN32_WINNT in the mingw-clang toolchain to 0x601 r?Build

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/786ebd1fc7fd
Bump the default value of _WIN32_WINNT in the mingw-clang toolchain to 0x601. r=froydnj

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/786ebd1fc7fd

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 9036180 [details] [diff] [review]
Bug 1518544 - Bump the default value of _WIN32_WINNT in the mingw-clang toolchain to 0x601 r?Build

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Keeps esr60 and central in sync for the mingw-clang build.

User impact if declined: The builds will be slightly out of sync, and may require more work to land patches.

Fix Landed on Version: 66.0a1 / 20190115103851

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Only affects the mingw-clang build. Very minor patch.

String or UUID changes made by this patch:

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9036180 [details] [diff] [review]
Bug 1518544 - Bump the default value of _WIN32_WINNT in the mingw-clang toolchain to 0x601 r?Build

mingw-clang build update, npotb

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/c7cba7f60631