[wpt-sync] Sync PR 14750 - canvas: Restore the data: URL special case for tainting.
Categories
(Testing :: web-platform-tests, enhancement, P4)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14750 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/14750
Details from upstream follow.
Matt Falkenhagen <falken@chromium.org> wrote:
canvas: Restore the data: URL special case for tainting.
CanvasRenderingContext::WouldTaintOrigin() had a special case for data
URLs that was removed in r610498.[1] The assumption was that just calling
CanvasImageSource::WouldTaintOrigin() would return false on data URLs.
It turns out that function can return true due to a historical
restriction on SVG foreign object nodes, as discussed in bug 294129.This CL reverses that behavior change, so data URLs again don't taint
the canvas. It partially reverts r610498 and dependent change r613433.A WPT test is added. Chrome now passes the test despite bug 294129 being
open because it has this special case for data URLs on canvas.[1] https://chromium-review.googlesource.com/c/chromium/src/+/1347953
Bug: 294129, 918460
Change-Id: I7c8cb4d37d950693956785c291dfd7660c42e662
Reviewed-on: https://chromium-review.googlesource.com/1400433
WPT-Export-Revision: e2fed8597ebc3834f92d91297b67b0f7485d8c8e
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=680f8a4f067ed466f0a437172b777a42136d8205
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=47251b3bf945679064a1de141ed7d7f036f314cc
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/831fbc3b08b5 [wpt PR 14750] - canvas: Restore the data: URL special case for tainting., a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/74bc4bd79017 [wpt PR 14750] - canvas: Restore the data: URL special case for tainting., a=testonly
Comment 5•5 years ago
|
||
bugherder |
Description
•