Closed Bug 1518584 Opened 1 year ago Closed 1 year ago

General cleanups to FrameMetrics and RepaintRequest

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: botond, Assigned: botond)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

I'd like to clean up the representation of viewports and scroll offsets in FrameMetrics and RepaintRequests a bit, to align better with the recent changes related to the visual vs. layout viewport distinction.

I'm going to start with some general cleanups in this bug.

Also make a const-correctness fix to PointTyped::WithinEpsilonOf().

Depends on D15974
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5029552447c1
Update out-of-date comments in FrameMetrics.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/465d94722195
Corresponding comment changes in RepaintRequest.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/01f03c4f2600
Remove {FrameMetrics,RepaintRequest}::mUseDisplayPortMargins. r=kats
https://hg.mozilla.org/integration/autoland/rev/3d58d90a9bc4
Rename {FrameMetrics,RepaintRequest}::mViewport to mLayoutViewport. r=kats
https://hg.mozilla.org/integration/autoland/rev/f12fba5d2706
Simplify some comparisons involving the layout viewport. r=kats
https://hg.mozilla.org/integration/autoland/rev/541282f7d798
Add WithinEpsilonOf() functions to RectTyped and MarginTyped. r=kats
https://hg.mozilla.org/integration/autoland/rev/f9e54ff712bc
Use WithinEpsilonOf() to clean up the comparisons in RequestContentRepaint(). r=kats
You need to log in before you can comment on or make changes to this bug.