1518608 - Treeherder does not recognize FirefoxAccount logins

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Guillaume Destuynder [:kang] [this account is no longer active]]

See https://discourse.mozilla.org/t/cant-login-to-treeherder-mozilla-org/34905

This is caused by: https://github.com/mozilla/treeherder/blob/b621781f2606000bac3693eb324e8e565728682c/treeherder/auth/backends.py#L72-L81

A Firefox Accounts user_id (sub) starts with oauth2| and contains firefoxaccounts, such as oauth2|firefoxaccounts|1cfec661bd504cd3a5742745549576a1

Note that while this value is not opaque in practice, user ids (sub) are normally considered opaque, which means that it's guaranteed to always contain the data you're looking for. In practice, today, it does always contain it though.

Comment 1

[Hassan Ali (:hassan)]

https://github.com/mozilla/treeherder/pull/4436

Comment 2

[Ed Morley [:emorley]]

Fixed by:
https://github.com/mozilla/treeherder/commit/45b2493d06e279a0ed0add0e04bfbb9d71ca6510