Pref on ASR Snippets for 65 Beta and Release
Categories
(Firefox :: Messaging System, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox64 | --- | unaffected |
firefox65 | + | verified |
firefox66 | + | verified |
People
(Reporter: tspurway, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
ASR Snippets are being rolled out in 64 Release using Normandy's roll-out pref flipping mechanism.
Let's make this change permanent by uplifting a patch to pref ASR Snippets on in 65 beta after we have made sure the roll-out has gone as planned.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Tim, any updates on this? RC week is next week and there's only one more Beta build scheduled this week.
Reporter | ||
Comment 2•5 years ago
|
||
Snippets is being rolled out in 64, and is currently at 25%. Everything looks good so far. Nan, let's get this pref change landed and request uplift to beta.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06f2abbc4a59 Pref on ASR Snippets for 65 Beta and Release r=k88hudson
Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9036689 [details]
Bug 1518619 - Pref on ASR Snippets for 65 Beta and Release
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1513279
User impact if declined: Wrong snippets experience
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Just setting the pref to be default enabled to match the same value that will reach 100% rollout on January 17th
String changes made/needed: none
Comment 6•5 years ago
|
||
We want QA to verify that this is working correctly when preffed on.
Comment 7•5 years ago
|
||
Comment on attachment 9036689 [details]
Bug 1518619 - Pref on ASR Snippets for 65 Beta and Release
[Triage Comment]
Permanently prefs on ASR Snippets by default, which was already the case for 64 via Normandy. Approved for 65.0b12.
Comment 8•5 years ago
|
||
bugherder uplift |
Comment 9•5 years ago
|
||
bugherder |
Comment 10•5 years ago
|
||
I have verified this issue with the latest Firefox Beta (65.0b12 Build ID - 20190117232427) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now the ASR Snippets are on by default and are correctly triggered according to their targeting parameters.
Assignee | ||
Updated•5 years ago
|
Description
•