Closed Bug 1518619 Opened 11 months ago Closed 11 months ago

Pref on ASR Snippets for 65 Beta and Release

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.3 - Jan 7 - 20
Tracking Status
firefox64 --- unaffected
firefox65 + verified
firefox66 + verified

People

(Reporter: tspurway, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

ASR Snippets are being rolled out in 64 Release using Normandy's roll-out pref flipping mechanism.

Let's make this change permanent by uplifting a patch to pref ASR Snippets on in 65 beta after we have made sure the roll-out has gone as planned.

Tim, any updates on this? RC week is next week and there's only one more Beta build scheduled this week.

Flags: needinfo?(tspurway)

Snippets is being rolled out in 64, and is currently at 25%. Everything looks good so far. Nan, let's get this pref change landed and request uplift to beta.

Flags: needinfo?(tspurway) → needinfo?(najiang)
Flags: needinfo?(najiang)
Assignee: nobody → edilee
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06f2abbc4a59
Pref on ASR Snippets for 65 Beta and Release r=k88hudson

Comment on attachment 9036689 [details]
Bug 1518619 - Pref on ASR Snippets for 65 Beta and Release

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1513279

User impact if declined: Wrong snippets experience

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Just setting the pref to be default enabled to match the same value that will reach 100% rollout on January 17th

String changes made/needed: none

Attachment #9036689 - Flags: approval-mozilla-beta?

We want QA to verify that this is working correctly when preffed on.

Flags: qe-verify+

Comment on attachment 9036689 [details]
Bug 1518619 - Pref on ASR Snippets for 65 Beta and Release

[Triage Comment]
Permanently prefs on ASR Snippets by default, which was already the case for 64 via Normandy. Approved for 65.0b12.

Attachment #9036689 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

I have verified this issue with the latest Firefox Beta (65.0b12 Build ID - 20190117232427) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now the ASR Snippets are on by default and are correctly triggered according to their targeting parameters.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.