1518633 - Consider adding a profiler label for anchor node selection

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Anchor node selection [1] is a pretty involved frame tree traversal. Scroll anchoring does its best to batch and defer this, but it's possible it could take a non-trivial amount of time on some pages.

It might make sense to have a profiler label here so we could identify when this is happening.

[1] https://drafts.csswg.org/css-scroll-anchoring-1/#anchor-node-selection

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1518633 - Add profiler label for anchor node selection. r?mstange

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1518633 part 15 - Remove unneeded mouse click test_bug633762. r?mattwoodrow

This mouse click seems superfluous, as window.focus() is called immediately after.

In addition, this click is somehow causing a page up scroll, as it's clicking
a slider frame. This causes the test to fail with scroll anchoring enabled,
for some reason. Removing this click seems to be the easiest solution, as it
doesn't seem intentional.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad851d4345c0
part 15 - Remove unneeded mouse click test_bug633762. r=mattwoodrow

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Ugh, wrong bug number for that commit. It should be bug 1305957.

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ad851d4345c0

Comment 6

[Ryan Hunt [:rhunt] (on leave until early May)]

This shouldn't block release of scroll anchoring.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f184a902803
Add profiler label for anchor node selection. r=mstange

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5f184a902803