Closed
Bug 1518703
Opened 5 years ago
Closed 5 years ago
Remove R_386_PC32 check
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I just stumbled upon this nugget in top-level Makefile.in:
# Look for R_386_PC32 relocations in shared libs, these
# break x86_64 builds and SELinux users.
ifeq ($(OS_TARGET)_$(TARGET_XPCOM_ABI),Linux_x86-gcc3)
check::
@relcount=`find $(DIST)/bin -name '*.so' | xargs objdump -R | grep R_386_PC32 | wc -l` && if test $$relcount -gt 0; then echo 'FAILED: R_386_PC32 relocations detected in a shared library. Did you use a system header without adding it to config/system-headers?'; exit 1; else echo 'PASSED'; fi
endif
This ought to be handled in python/mozbuild/mozbuild/action/check_binary.py nowadays, but in fact, the TEXTREL check in there is essentially checking the same thing, so we effectively already have the same test in check_binary.py.
Assignee | ||
Comment 1•5 years ago
|
||
The test is actually redundant with the TEXTREL check in check_binary.py (R_386_PC32 relocations will only happen as text relocations)
Updated•5 years ago
|
Blocks: nomakefiles
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/64255d8e90fe Remove R_386_PC32 check. r=froydnj,ted
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•