Closed Bug 1518713 Opened 11 months ago Closed 10 months ago

JavaScript warning for end_timestamp

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

Details

Attachments

(2 files)

I noticed this warning on the console while modifying the GCTelemetry unit test.

pid:15169 JavaScript strict warning: resource://gre/modules/GCTelemetry.jsm, line 57: ReferenceError: reference to undefined property "end_timestamp"

In the telemetry data I can see that end_timestamp is null (probably because of this code). I checked the code that writes this data in the GC. Sure enough, there's no end_timestamp property.

Do not try to process the end_timestamp propertly since slices have no such
property.

Assignee: nobody → pbone
Status: NEW → ASSIGNED
Attachment #9035229 - Flags: review?(florian)

By refactoring this test code we can more easily adjust the number of fields
there are supposed to be in these objects.

I originally put this patch on Bug 1517409 but I think it makes more sense here. r+ carried forward from florian.

Attachment #9035232 - Flags: review+
Blocks: 1517409

(Marking this as P1 just so that it shows up as currently being worked on in our Telemetry dashboards)

Priority: -- → P1

Comment on attachment 9035229 [details] [diff] [review]
Bug 1518713 - Slices have no end_timestamp

Review of attachment 9035229 [details] [diff] [review]:

I'm probably not the best reviewer for this, but it seems trivial enough, r=me.

Attachment #9035229 - Flags: review?(florian) → review+

(In reply to Florian Quèze [:florian] from comment #4)

Comment on attachment 9035229 [details] [diff] [review]
Bug 1518713 - Slices have no end_timestamp

Review of attachment 9035229 [details] [diff] [review]:

I'm probably not the best reviewer for this, but it seems trivial enough, r=me.

Thanks for the review Florian. You and gfritzsche where the most highly recommended people as voted by mrgiggles (the chatbot). Since you did the other patch here I decided to keep it the same. Thanks again.

Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f950f9e24121
Slices have no end_timestamp r=florian
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d91186df537
Make it easier to update the GC telemetry unit test r=florian
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.