1518746 - Intermittent netwerk/test/mochitests/test_accept_header.html | Test timed out.

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=220765340&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/cDUtI-u4SIS8zyuzvh067A/runs/0/artifacts/public/logs/live_backing.log

[task 2019-01-09T07:50:54.357Z] 07:50:54 INFO - 125 INFO TEST-START | netwerk/test/mochitests/test_accept_header.html
[task 2019-01-09T07:56:12.928Z] 07:56:12 INFO - 126 INFO TEST-UNEXPECTED-FAIL | netwerk/test/mochitests/test_accept_header.html | Test timed out.
[task 2019-01-09T07:56:12.928Z] 07:56:12 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:7
[task 2019-01-09T07:56:12.928Z] 07:56:12 INFO - reportError@SimpleTest/TestRunner.js:121:7
[task 2019-01-09T07:56:12.928Z] 07:56:12 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
[task 2019-01-09T07:56:12.928Z] 07:56:12 INFO - 127 INFO TEST-OK | netwerk/test/mochitests/test_accept_header.html | took 311547ms

Comment 1

[Intermittent Failures Robot]

19 failures in 2627 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10
• mozilla-inbound: 6
• mozilla-central: 3

Platform breakdown:

• android-em-4-3-armv7-api16: 17
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1518746&startday=2019-01-07&endday=2019-01-13&tree=all

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Looking at pushes around the date of the first failure this one is the most likely to affect the test in any way:
https://hg.mozilla.org/mozilla-central/rev/43c43fa35d2a

I assume the test just isn't expecting to get the favicon resource, but I haven't looked at it too closely.

Comment 3

[:Gijs (he/him)]

(In reply to Valentin Gosu [:valentin] from comment #2)

Looking at pushes around the date of the first failure this one is the most likely to affect the test in any way:
https://hg.mozilla.org/mozilla-central/rev/43c43fa35d2a

I assume the test just isn't expecting to get the favicon resource, but I haven't looked at it too closely.

Yeah, this looks like a trivial issue in the test, in that:

https://searchfox.org/mozilla-central/rev/c43240cef5829b8a2dec118faff8a5e1fec6ae1b/netwerk/test/mochitests/test_accept_header.html#26,30

disconnects the observer twice, which is already suspicious, but I suppose that maybe the favicon request trips the observer before we get the iframe request in there, and then the test just sits there doing nothing... though I don't see why the accept header would have made a difference for this test.

Comment 4

[Dave Townsend [:mossop]]

I suspect that bug 1516658 isn't at fault here. As Gijs says it should not have affected the timing of favicon requests, and checks of the accept header in this test are well guarded by uri checks (and additionally a bad accept header would have been logged as such it wouldn't cause a timeout). Also, the test doesn't include a favicon link anywhere, and attempts to load a site's root favicon are disabled in tests. I ran this locally with some modifications and saw no signs that favicons were loading.

The failure is pretty infrequent so catching it locally is pretty unlikely so lets fix some possible signs of problems and add some logging to see if we can figure out what is going on.

Comment 5

[Dave Townsend [:mossop]]

Attachment: Bug 1518746: Add additional logging to test_accept_header.html. r=valentin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/837ae1da7e4d
Add additional logging to test_accept_header.html. r=valentin

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/837ae1da7e4d

Comment 8

[Dave Townsend [:mossop]]

So the logging shows that the test consistently fails when testing the iframe or style cases (slightly more often in the style case). Those are the two tests that use the PerformanceObserver API to catch the load. Let's try switching to an alternate method.

Comment 9

[Dave Townsend [:mossop]]

Attachment: Bug 1518746: Switch to load events for all tested resources. r=valentin

Comment 10

[Intermittent Failures Robot]

34 failures in 2378 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 4
• autoland: 12
• mozilla-inbound: 14
• mozilla-central: 4

Platform breakdown:

• osx-10-10: 2
• linux64-devedition: 1
• linux64-qr: 5
• windows7-32: 1
• windows10-64: 1
• linux64: 1
• android-em-4-3-armv7-api16: 23

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1518746&startday=2019-01-14&endday=2019-01-20&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ff8ccd4e3d
Switch to load events for all tested resources. r=valentin

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a9ff8ccd4e3d

Comment 13

[Intermittent Failures Robot]

5 failures in 2383 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2
• mozilla-beta: 1
• mozilla-inbound: 2

Platform breakdown:

• linux64: 1
• android-em-4-3-armv7-api16: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1518746&startday=2019-01-21&endday=2019-01-27&tree=all