Add Tumblr to tp6
Categories
(Testing :: Raptor, defect, P1)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: davehunt, Assigned: Bebe)
References
Details
Attachments
(1 file)
This tracks adding Tumblr to tp6.
URL: http://barackobama.tumblr.com/post/41810401115
Use the credentials available in the shared 1Password vault.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
recorded the provided url but could not reproduce the login information.
as an alternative we could switch to the dashboard url: https://www.tumblr.com/dashboard
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #3)
recorded the provided url but could not reproduce the login information.
Do you mean the given credentials didn't work? I won't review this patch until that is resolved (or if it's decided to record a different URL instead), thanks.
|
Reporter | |
Comment 5•5 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #3)
recorded the provided url but could not reproduce the login information.
What do you mean here :bebe?
as an alternative we could switch to the dashboard url: https://www.tumblr.com/dashboard
I think this might be a better URL to use. vchin: are you happy with us using the dashboard with more content over the single post URL?
|
|
Assignee | |
Comment 6•5 years ago
|
||
:davehunt :rwwod
recorded the provided url but could not reproduce the login information.
Recorded the website successfully with working credentials.
But, when we do replay we can't see the logged-in tags and information on the top left of the page, looks like we are not logged in, even if we recorded the page with the user logged in.
|
|
Reporter | |
Comment 7•5 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #6)
Recorded the website successfully with working credentials.
But, when we do replay we can't see the logged-in tags and information on the top left of the page, looks like we are not logged in, even if we recorded the page with the user logged in.
I wonder if this is related to the cookies issue you recently saw with Microsoft Office. Can you try to replicate with the latest version of mitmproxy? Are you able to record/playback the logged in contents from the https://www.tumblr.com/dashboard URL?
|
|
Assignee | |
Comment 8•5 years ago
•
|
||
Tested this with mitmproxy 4.0.4:
Can't open a logged in page using the default url: http://barackobama.tumblr.com/post/41810401115
Tested with mitmproxy 2.0.2:
Test works successfully when opening https://www.tumblr.com/dashboard
To go forward with this test I would suggest to switch to https://www.tumblr.com/dashboard
|
|
Reporter | |
Comment 9•5 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #8)
Tested this with mitmproxy 4.0.4:
Can't open a logged in page using the default url: http://barackobama.tumblr.com/post/41810401115
Do you know why this isn't working? Could you open an issue against mitmproxy? I'm concerned that whatever the issue is here may be causing other less obvious issues. This would be a scenario to test when considering alternatives to mitmproxy.
Tested with mitmproxy 2.0.2:
Test works successfully when opening https://www.tumblr.com/dashboardTo go forward with this test I would suggest to switch to https://www.tumblr.com/dashboard
Yes, let's do that. I'll leave the needinfo for :vchin open in case we need to reverse that decision.
|
|
Assignee | |
Comment 11•5 years ago
•
|
||
Updated to use https://www.tumblr.com/dashboard
Please review
recording at https://drive.google.com/open?id=1ABVJw5vbaUo0BfRho9z38ZUCt5eZcayM
|
|
||
Comment 12•5 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #11)
Updated to use https://www.tumblr.com/dashboard
Please review
recording at https://drive.google.com/open?id=1ABVJw5vbaUo0BfRho9z38ZUCt5eZcayM
Works on OSX on Firefox and Chromium, uploaded to tooltool (manifest is in phab).
|
||
Comment 13•5 years ago
|
||
Pushed by fstrugariu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03904adbe563 Add Tumblr to tp6 r=rwood
|
|
||
Comment 14•5 years ago
|
||
In the future before landing please add the link to your try run - running on Firefox and Chrome on all platforms with a few retriggers, to ensure stability - and with screen captures would be good too so you can visually verify it looks correct on all platforms. Thanks :)
|
|
Assignee | |
Comment 15•5 years ago
|
||
|
||
Comment 16•5 years ago
|
||
| bugherder | ||
|
||
Comment 17•5 years ago
|
||
The change to the dashboard link is fine.
Did we open an issue against mitmproxy? Can you provide a link to the issue?
|
|
Reporter | |
Comment 18•5 years ago
|
||
:bebe as we now support mitmproxy 4 and have made a number of changes to the server replay addon, can you see if the issue with http://barackobama.tumblr.com/post/41810401115 whilst logged in still exists?
|
|
Assignee | |
Comment 19•5 years ago
|
||
Tried to record http://barackobama.tumblr.com/post/41810401115 with mitmproxy 4.0.4 and failed.
I got an "Secure Connection Failed"
So updating to 4.0.4 did not helped in this case.
|
|
Reporter | |
Comment 20•5 years ago
|
||
:bebe If you can replicate this without our custom server replay addon then we should raise an issue against the mitmproxy project. If not, we should understand what's causing this to fail.
Description
•