1518786 - Add Security Exception window sizing issues

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Attachment: AddSecurityException_BottomPadding_Get.png

[Affected versions]:

• 65.0b9, 65.0b9devED

[Affected platforms]:

• Windows 10, Ubuntu 18.04

[Steps to reproduce]:

1. Access https://forum.kaspersky.com/index.php?/topic/403934-possible-fake-emails-from-kasperskyuk/
2. Click on the Advanced button;
3. Click on the Add Exception button;
4. Click on the Get Certificate button;

[Expected result]:

• the window is properly displayed

[Actual result]:

• step.3: bottom_padding is needed the Permanently store this exception option;
• step.4: window displayed at what seems to be the min-height; buttons they appear truncated;

[Regression range]:

• issue appears to be limited to the beta 9 builds;

[Additional notes]:

• attached screenshot with the issue;
• macOS(10.13) does not seem to be affected by this issue;
• on Ubuntu, resizing of the window is possible;

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Can you please provide a regression range for this?

Comment 2

[Cristian Fogel [:cfogel]]

Swapping browser.security.newcerterrorpage.enabled to false, I was able to check for the regression properly.

Pushlog URL: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dd2f3ac3a0baa2993f64a7fdcde82592e09a375c&tochange=33a1a7271fe37f0e5118dc71381f7e29d3809a89

Mozregression points to: bug 1498448

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Zibi, not sure if the MSU folks are still active - can you take a look at this? We've got about a week left in the Fx65 beta cycle.

Comment 4

[:Gijs (he/him)]

As a quick untested suggestion, I wonder if we can call dialog.sizeToContent() after fluent finishes localizing.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

This seems minor enough that I'd prefer not to prioritize it over my current tasks. Adding it to the capstone backlog.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r?Gijs

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1518786 - Remove translations from the pending queue if there is a caller that is waiting on the specific translations.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2677d2e45ead
Wait until Fluent strings have been applied before sizing the window to content. r=Gijs

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfbd8823f3c5
Remove translations from the pending queue if there is a caller that is waiting on the specific translations. r=zbraniecki

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2677d2e45ead
https://hg.mozilla.org/mozilla-central/rev/cfbd8823f3c5

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs (reduced patch for beta65)

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9037283 [details]
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs (reduced patch for beta65)

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498448

User impact if declined: Users will not be able to add security exceptions

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This change waits until all strings have been localized before sizing the window to fit the content of the new strings. It uses existing APIs and just delays the sizing of the window until slightly later than it already was.

String changes made/needed: none

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Note, to test this on Nightly66 you will need to go to about:config and set browser.security.newcerterrorpage.enabled to false

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9037283 [details]
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs (reduced patch for beta65)

[Triage Comment]
Fixes window sizing issues causing users to be unable to add security exceptions under some circumstances. Approved for 65.0b12.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0f24bd868b5

Comment 20

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming this issue as verified fixed on the latest FF Nightly 66.0a1(BuildID:20190117215514) and 65.0b12(BuildID:20190117232427) on Windows 10.x64 and Ubuntu 18.04x64.

Comment 22

[Walter Labonte]

Attachment: cert.png

I have confirmed it's OK now on Nightly 2019-01-18. Thanks for fixing!