Add Security Exception window sizing issues

VERIFIED FIXED in Firefox 65

Status

()

P1
normal
VERIFIED FIXED
a month ago
a month ago

People

(Reporter: cfogel, Assigned: jaws)

Tracking

({regression})

65 Branch
mozilla66
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65+ verified, firefox66+ verified)

Details

(Whiteboard: [psm-assigned])

Attachments

(5 attachments)

(Reporter)

Description

a month ago

Created attachment 9035300 [details]
AddSecurityException_BottomPadding_Get.png

[Affected versions]:

  • 65.0b9, 65.0b9devED

[Affected platforms]:

  • Windows 10, Ubuntu 18.04

[Steps to reproduce]:

  1. Access https://forum.kaspersky.com/index.php?/topic/403934-possible-fake-emails-from-kasperskyuk/
  2. Click on the Advanced button;
  3. Click on the Add Exception button;
  4. Click on the Get Certificate button;

[Expected result]:

  • the window is properly displayed

[Actual result]:

  • step.3: bottom_padding is needed the Permanently store this exception option;
  • step.4: window displayed at what seems to be the min-height; buttons they appear truncated;

[Regression range]:

  • issue appears to be limited to the beta 9 builds;

[Additional notes]:

  • attached screenshot with the issue;
  • macOS(10.13) does not seem to be affected by this issue;
  • on Ubuntu, resizing of the window is possible;
Component: General → Security: PSM
Product: Firefox → Core

Can you please provide a regression range for this?

Flags: needinfo?(cristian.fogel)
Keywords: regressionwindow-wanted
(Reporter)

Comment 2

a month ago
regression-window

Swapping browser.security.newcerterrorpage.enabled to false, I was able to check for the regression properly.

Pushlog URL: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dd2f3ac3a0baa2993f64a7fdcde82592e09a375c&tochange=33a1a7271fe37f0e5118dc71381f7e29d3809a89

Mozregression points to: bug 1498448

Flags: needinfo?(cristian.fogel)
Keywords: regressionwindow-wanted

Zibi, not sure if the MSU folks are still active - can you take a look at this? We've got about a week left in the Fx65 beta cycle.

Blocks: 1498448
status-firefox66: --- → affected
Flags: needinfo?(gandalf)

Comment 4

a month ago

As a quick untested suggestion, I wonder if we can call dialog.sizeToContent() after fluent finishes localizing.

This seems minor enough that I'd prefer not to prioritize it over my current tasks. Adding it to the capstone backlog.

Blocks: 1486917
Flags: needinfo?(gandalf)
Duplicate of this bug: 1519186
Duplicate of this bug: 1479325
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Created attachment 9036676 [details]
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r?Gijs
Created attachment 9036677 [details]
Bug 1518786 - Remove translations from the pending queue if there is a caller that is waiting on the specific translations.
Priority: -- → P1
Whiteboard: [psm-assigned]

Updated

a month ago
Duplicate of this bug: 1520382
tracking-firefox65: --- → +
tracking-firefox66: --- → +
Flags: qe-verify+

Comment 11

a month ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2677d2e45ead
Wait until Fluent strings have been applied before sizing the window to content. r=Gijs

Comment 12

a month ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfbd8823f3c5
Remove translations from the pending queue if there is a caller that is waiting on the specific translations. r=zbraniecki

Comment 13

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Please nominate this for Beta approval when you get a chance.

status-firefox-esr60: --- → unaffected
Flags: needinfo?(jaws)

Created attachment 9037283 [details]
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs (reduced patch for beta65)

Comment on attachment 9037283 [details]
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs (reduced patch for beta65)

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498448

User impact if declined: Users will not be able to add security exceptions

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This change waits until all strings have been localized before sizing the window to fit the content of the new strings. It uses existing APIs and just delays the sizing of the window until slightly later than it already was.

String changes made/needed: none

Flags: needinfo?(jaws)
Attachment #9037283 - Flags: approval-mozilla-beta?

Note, to test this on Nightly66 you will need to go to about:config and set browser.security.newcerterrorpage.enabled to false

Comment on attachment 9037283 [details]
Bug 1518786 - Wait until Fluent strings have been applied before sizing the window to content. r=Gijs (reduced patch for beta65)

[Triage Comment]
Fixes window sizing issues causing users to be unable to add security exceptions under some circumstances. Approved for 65.0b12.

Attachment #9037283 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 19

a month ago
bugherderuplift
status-firefox65: affected → fixed

Confirming this issue as verified fixed on the latest FF Nightly 66.0a1(BuildID:20190117215514) and 65.0b12(BuildID:20190117232427) on Windows 10.x64 and Ubuntu 18.04x64.

Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
status-firefox66: fixed → verified
Flags: qe-verify+
See Also: → bug 1521034
Duplicate of this bug: 1517315

Comment 22

a month ago

Created attachment 9037646 [details]
cert.png

I have confirmed it's OK now on Nightly 2019-01-18. Thanks for fixing!

Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.