1518792 - Re-add some styles after their removal in bug 1437641

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1437641 removes some styles we still need.

Comment 1

[Magnus Melin [:mkmelin]]

I've been thinking of getting rid of our forked textbox.xml bindings fairly soon. Doesn't appear to me we really need the forked code, but I'd have to check it more closely.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1518792-re-add-styles.patch

I know you are not a Linux reviewer but this are simple changes and the m-c bug could land on the next merge.

I haven't tested it with the m-c patch but checked with inspector. I also did code inspection and the other CSS changes shouldn't affect us because we have our own numberbox binding with spinbuttons and no ::-moz-number-spin-box, ::-moz-number-spin-up or ::-moz-number-spin-down.

Comment 3

[Richard Marti (:Paenglab)]

The difference to m-c are the spinbuttons which Firefox doesn't use.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9035306 [details] [diff] [review]
1518792-re-add-styles.patch

Adding Magnus to the review. So who ever is first should be enough.

Comment 5

[Tim Nguyen :ntim]

(In reply to Richard Marti (:Paenglab) from comment #3)

The difference to m-c are the spinbuttons which Firefox doesn't use.

spinbuttons are supposed to work on input[type=number], unfortunately, XUL flexbox breaks them. But apart from that issue, input[type=number] should really be a viable replacement to numberbox.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9035306 [details] [diff] [review]
1518792-re-add-styles.patch

Looks reasonable, restores this
https://hg.mozilla.org/mozilla-central/rev/00d33e7058c1#l26.12
and uses alternative images.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e43ba90ba5ec
Restore some styles after their removal in bug 1437641 and switch icon usage. r=jorgk

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1518792-fup.patch

Sorry, I was a bit in a hurry and forgot the, for our SVG needed, -moz-context-properties to follow the OS theme text color.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0540daeda24
Follow-up: Add the -moz-context-properties for the SVG in sanitizeDialog. r=jorgk