Closed Bug 1518792 Opened 9 months ago Closed 9 months ago

Re-add some styles after their removal in bug 1437641

Categories

(Thunderbird :: Theme, enhancement)

All
Linux
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 66.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Bug 1437641 removes some styles we still need.

I've been thinking of getting rid of our forked textbox.xml bindings fairly soon. Doesn't appear to me we really need the forked code, but I'd have to check it more closely.

I know you are not a Linux reviewer but this are simple changes and the m-c bug could land on the next merge.

I haven't tested it with the m-c patch but checked with inspector. I also did code inspection and the other CSS changes shouldn't affect us because we have our own numberbox binding with spinbuttons and no ::-moz-number-spin-box, ::-moz-number-spin-up or ::-moz-number-spin-down.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9035306 - Flags: review?(jorgk)

The difference to m-c are the spinbuttons which Firefox doesn't use.

Comment on attachment 9035306 [details] [diff] [review]
1518792-re-add-styles.patch

Adding Magnus to the review. So who ever is first should be enough.

Attachment #9035306 - Flags: review?(mkmelin+mozilla)

(In reply to Richard Marti (:Paenglab) from comment #3)

The difference to m-c are the spinbuttons which Firefox doesn't use.

spinbuttons are supposed to work on input[type=number], unfortunately, XUL flexbox breaks them. But apart from that issue, input[type=number] should really be a viable replacement to numberbox.

Comment on attachment 9035306 [details] [diff] [review]
1518792-re-add-styles.patch

Looks reasonable, restores this
https://hg.mozilla.org/mozilla-central/rev/00d33e7058c1#l26.12
and uses alternative images.

Attachment #9035306 - Flags: review?(mkmelin+mozilla)
Attachment #9035306 - Flags: review?(jorgk)
Attachment #9035306 - Flags: review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e43ba90ba5ec
Restore some styles after their removal in bug 1437641 and switch icon usage. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0

Sorry, I was a bit in a hurry and forgot the, for our SVG needed, -moz-context-properties to follow the OS theme text color.

Attachment #9035377 - Flags: review?(jorgk)
Attachment #9035377 - Flags: review?(jorgk) → review+
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a0540daeda24
Follow-up: Add the -moz-context-properties for the SVG in sanitizeDialog. r=jorgk

Status: REOPENED → RESOLVED
Closed: 9 months ago9 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.