[Content Blocking] Blue label from Tracking list in "Show site information" is hardly visible on High Contrast mode

VERIFIED FIXED in Firefox 69

Status

()

defect
P3
normal
VERIFIED FIXED
7 months ago
28 days ago

People

(Reporter: david.olah, Assigned: gvelchuru)

Tracking

Trunk
Future
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox65 wontfix, firefox66 wontfix, firefox69 verified)

Details

Attachments

(2 attachments)

Posted image Label_block.png

[Enviroments:]
Windows 10, Windows 7
66.0a1 (2019-01-09)

[Steps:]

  1. Set a high contrast theme (example: black).
  2. Open Firefox.
  3. Go to a website (ex: https://www.dailymotion.com/us)
  4. Open the "Show site information"
  5. Click the Trackers list to open

[Actual Result:]
Blue label with message <To block all trackers, set Content blocking to "Strict"> is hardly visible.

[Expected Result:]
Blue label with message <To block all trackers, set Content blocking to "Strict"> is clearly visible.

[Note]
In the Attachments you can see the label marked.

Priority: -- → P3
Target Milestone: --- → Future

Gautham, are you interested to take this?

In order to debug this, besides setting your system to be in High Contrast mode, you need to use our devtools to debug the Firefox UI, which is fun!

On Nightly you can do that by opening devtools (for example by Ctrl+Shift+I/Cmd+Shift+I), pressing the "..." button, Settings, and making sure both "Enable browser chrome and add-on debugging toolboxes" and "Enable remote debugging" checkboxes are checked. Then you can open the Browser Toolbox by pressing Ctrl+Shift+Alt+I. This allows you to remote debug the browser UI using the same tools that you can use to debug web pages. Since this UI is inside a pop-up, from the "..." button in Browser Toolbox select "Disable Pop-up Auto-Hide" which makes sure pop-ups remain open on the window until explicitly closed. Then you can use the Inspector tool to examine what styles are applied to the blue control versus the controls around it and where the style properties are coming from. The most interesting style property you'd want to adjust is the color property. The fix to this bug is probably either overriding that property somewhere or removing an override that may be being used inappropriately to give us the dark blue text colour.

See bug 1518807 for a similar bug fix (bug in another part of the browser UI) to get some ideas.

I'd love to take this! Thank you for the information, I'll take a look.

Attachment #9072863 - Attachment description: Bug 1518810 - change color of show site information to black → Bug 1518810 - remove blue color of site information
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/303b1fcafdeb
remove blue color of site information r=dao
Assignee: nobody → gvelchuru
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Flags: qe-verify+
Flags: needinfo?(ciprian.georgiu)

Verified as fixed on Windows 10x64 and Windows 7x64 with 69.0b6.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(ciprian.georgiu)
You need to log in before you can comment on or make changes to this bug.