Handle cross-compartment wrapped TypedArrays in TypedArray[@@toStringTag]

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago
No description provided.
Assignee

Comment 1

4 months ago

Applies on top of bug 1518764.

In bug 1518764 I've already introduced UnwrapAndDowncastValue for intrinsic_ConstructorForTypedArray, the function which is directly above intrinsic_NameForTypedArray, so I think it makes sense to use UnwrapAndDowncastValue here, too.

Attachment #9035349 - Flags: review?(jorendorff)
Comment on attachment 9035349 [details] [diff] [review]
bug1518833.patch

Review of attachment 9035349 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

It seems like it would be less code to implement the getter in C++ and drop the intrinsic.
Attachment #9035349 - Flags: review?(jorendorff) → review+
Assignee

Comment 4

4 months ago

(In reply to Jason Orendorff [:jorendorff] from comment #2)

It seems like it would be less code to implement the getter in C++ and drop
the intrinsic.

Agreed. I didn't see any obvious comments in bug 1114580 (where this function was added) to explain why a self-hosted version is more useful to have. Well, there is bug 1114580, comment #43, in which the reviewer suggested to maybe rewrite the whole function in C++. Maybe could check with the reviewer from back then, if he still has the same opinion today. :-)

Comment 5

4 months ago

Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a01aa85fc04
Handle cross-compartment wrapped TypedArray in @@toStringTag. r=jorendorff

Keywords: checkin-needed

Comment 6

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.