1518834 - Muting locally on appear.in freezes video

Status: VERIFIED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Description

[Nils Ohlmeier [:drno]]

When muting the local audio input on appear.in the local preview video freezes as well. Furthermore the video send to the remote side also freezes. If the participant is muted when another party joins the call, the new joiner doesn't get any video until the first party un-mutes him/her-self.

Mozregression run points at bug 1513973.

Comment 1

[Nils Ohlmeier [:drno]]

Andreas can you please have a look?

Comment 2

[Alex Chronopoulos [:achronop]]

It must be the following line:
https://searchfox.org/mozilla-central/rev/5053031ba7621fa8f63f42de4c204ab3561e4e59/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#614
On mute MediaEngineWebRTCMicrophoneSource::Stop is called but we do not want to disable pulling more data.

Comment 3

[Andreas Pehrson [:pehrsons]]

With pulling disabled we're supposed to still advance the track when data runs out I thought. Or does it only hold true for video?

I'll do the minimal necessary to revert this, and then file a followup to restore and fix this, including a mochitest to make sure we're not regressing it again.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1518834 - Don't disable pulling when stopping microphone source. r?drno

Comment 5

[Andreas Pehrson [:pehrsons]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a95e592dc3e1bc2dddb45c08a3d6ad9df17755dd

I also verified the mac build locally for both debug and non-debug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d3e6c915370
Don't disable pulling when stopping microphone source. r=drno

Comment 7

[Andreas Pehrson [:pehrsons]]

Comment on attachment 9035533 [details]
Bug 1518834 - Don't disable pulling when stopping microphone source. r?drno

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1513973

User impact if declined: Disabling an audio track will freeze the video track if both tracks come from the same getUserMedia-request.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Go to https://appr.tc/r/975803237
Approve the mic and camera request
Click the microphone button to mute your local audio
Expected: video continues
Actual: video freezes

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial

String changes made/needed:

Comment 8

[Alex Chronopoulos [:achronop]]

I've verified Linux build with that fix.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6d3e6c915370

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9035533 [details]
Bug 1518834 - Don't disable pulling when stopping microphone source. r?drno

[Triage Comment]
Fixes video pausing when the audio is muted under some circumstances. Approved for 65.0b10.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aaeaf42a092d

Comment 12

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 66.0a1 (BuildId:20190109214248).

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190111093148) and Firefox 65.0b10 (BuildId:20190110221328) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

The video no longer freezes after muting the local audio input.