1518841 - Allow embedders to load WebExtensions in GV

Status: RESOLVED FIXED

(GeckoView :: Extensions, enhancement, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

We have many requests for letting embedders to be able to load WebExtensions into GeckoView (e.g. content scripts).

This is about a very simple support for WebExtensions. Support for enabling/disabling and any UI elements will follow in other bugs.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

You mentioned that in your prototype you were able to WebExtensions from the APK. Will it be possible to load them from the filesystem too in this iteration?

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

You will be able to load web extensions from either:

• A folder in the apk
• A .xpi in the file system (anywhere where the app has read permissions)

would that be enough?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Perfect. Thank you. :)

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1522137 - Make resource://android return a nsIJARURI. r=mayhemer!

Comment 6

[Phabricator Automation]

Comment on attachment 9037413 [details]
Bug 1522137 - Make resource://android return a nsIJARURI. r=mayhemer!

Revision D16913 was moved to bug 1522137. Setting attachment 9037413 [details] to obsolete.

Comment 7

[Chris Peterson [:cpeterson]]

Adding [geckoview:fenix:m2] whiteboard tag because the Fenix team says they would like to start using WebExtensions for ad blocking and reader mode in their Fenix M2 or M3 milestones.

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5759c935a9b4f2da60d681d1aee5db3fc991a154

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51467afba450
Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin

Comment 10

[Andreea Pavel [:apavel]]

Backed out for failing eslint at GeckoViewWebExtension.jsm

Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=230335107&revision=51467afba45054b651e009f531b67247a4943471

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230335107&repo=autoland&lineNumber=283

Backout: https://hg.mozilla.org/integration/autoland/rev/fffdf329fefd39b354500181a85b65eb62154438

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

Of course the one line change I don't send to try breaks the lint. Will fix shortly. Thank you.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2969ec6e0436
Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2969ec6e0436

Comment 14

[Chris Peterson [:cpeterson]]

[geckoview:fenix:m2] not [geckoview:fenix:p1]

Comment 15

[Chris Peterson [:cpeterson]]

Moving some WebExtension bugs to the GeckoView::Extensions component.