Allow embedders to load WebExtensions in GV

RESOLVED FIXED in Firefox 67

Status

Product:
GeckoView
Component:
General
Type:
enhancement
Importance:
P1
normal
Status:
RESOLVED FIXED
Opened:
5 months ago
Updated:
4 months ago

People

(Reporter: agi, Assigned: agi)

Tracking

(Blocks 1 bug)

Version:
Trunk
Target:
mozilla67
Platform:
All
Android
Dependency tree / graph

Firefox Tracking Flags

(geckoview64 wontfix, geckoview65 wontfix, firefox-esr60 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 wontfix, firefox67 fixed)

Details

(Whiteboard: [geckoview:fenix:m2])

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin
47 bytes, text/x-phabricator-request
Details | Review
Assignee

Description

•
5 months ago

We have many requests for letting embedders to be able to load WebExtensions into GeckoView (e.g. content scripts).

This is about a very simple support for WebExtensions. Support for enabling/disabling and any UI elements will follow in other bugs.

Comment 1

•
5 months ago

You mentioned that in your prototype you were able to WebExtensions from the APK. Will it be possible to load them from the filesystem too in this iteration?
Assignee

Comment 2

•
5 months ago

You will be able to load web extensions from either:

  • A folder in the apk
  • A .xpi in the file system (anywhere where the app has read permissions)

would that be enough?

Priority: -- → P1
Whiteboard: [gvtv]

Comment 3

•
5 months ago

Perfect. Thank you. :)

status-firefox64: --- → wontfix
status-firefox65: --- → wontfix
status-firefox66: --- → fix-optional
status-firefox-esr60: --- → wontfix
status-geckoview64: --- → wontfix
status-geckoview65: --- → wontfix
Whiteboard: [gvtv] → [geckoview:fenix:p1] [gvtv]
Attachment #9037413 - Attachment description: Bug 1518841 - Support android://assets for files inside the APK. r?snorp! → Bug 1522137 - Make resource://android return a nsIJARURI. r=mayhemer!

Comment 6

•
5 months ago

Comment on attachment 9037413 [details]
Bug 1522137 - Make resource://android return a nsIJARURI. r=mayhemer!

Revision D16913 was moved to bug 1522137. Setting attachment 9037413 [details] to obsolete.

Attachment #9037413 - Attachment is obsolete: true
Whiteboard: [geckoview:fenix:p1] [gvtv] → [geckoview:fenix:p1]

Comment 7

•
4 months ago

Adding [geckoview:fenix:m2] whiteboard tag because the Fenix team says they would like to start using WebExtensions for ad blocking and reader mode in their Fenix M2 or M3 milestones.

status-firefox66: fix-optional → wontfix
status-firefox67: --- → affected
Whiteboard: [geckoview:fenix:p1] → [geckoview:fenix:p1] [geckoview:fenix:m2]
Blocks: 1509257
Attachment #9035818 - Attachment description: Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r?snorp,esawin → Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin
Attachment #9035818 - Attachment description: Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin → Bug 1518841 - Allow embedders to load WebExtensions in GeckoView.

Comment 9

•
4 months ago 
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51467afba450
Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin
 Assignee

Comment 11

•
4 months ago

Of course the one line change I don't send to try breaks the lint. Will fix shortly. Thank you.

Flags: needinfo?(agi)
Attachment #9035818 - Attachment description: Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. → Bug 1518841 - Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin

Comment 12

•
4 months ago 
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2969ec6e0436
Allow embedders to load WebExtensions in GeckoView. r=snorp,esawin

Comment 13

•
4 months ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2969ec6e0436

Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1482231

Comment 14

•
4 months ago

[geckoview:fenix:m2] not [geckoview:fenix:p1]

Whiteboard: [geckoview:fenix:p1] [geckoview:fenix:m2] → [geckoview:fenix:m2]
You need to log in before you can comment on or make changes to this bug.