1518842 - mach test produces error during websocket/process bridge startup: ImportError: DLL load failed: %1 is not a valid Win32 application.

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Seeing issues attempting to run tests on Windows 10. Build works fine (just did a full build prior to attempting tests), but something appears unhappy in the test startup code. Note, the test still run, but it appears that the websocket/process bridge startup fails along the way.

STR:

• Using Mozilla central commit/changeset 26808f3dc0fe
• mach test dom/media/test/test_background_video_ended_event.html
• Error, partial log below

Requirement already satisfied: six==1.10.0 in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from -r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 2))
Requirement already satisfied: twisted==10.2.0 in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from -r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 4))
Requirement already satisfied: txws==0.9.1 in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from -r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 7))
Requirement already satisfied: psutil==5.4.3 in c:\projects\mozilla-central\third_party\python\psutil-cp27-none-win_amd64 (from -r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 9))
Requirement already satisfied: ipaddr==2.1.11 in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from -r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 12))
Requirement already satisfied: passlib==1.6.5 in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from -r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 13))
Requirement already satisfied: zope.interface in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from twisted==10.2.0->-r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 4))
Requirement already satisfied: setuptools in c:\projects\mozilla-builds\obj-ff-dbg-opt\_virtualenvs\init\lib\site-packages (from zope.interface->twisted==10.2.0->-r c:/Projects/mozilla-central\testing\tools\websocketprocessbridge\websocketprocessbridge_requirements.txt (line 4))
You are using pip version 9.0.3, however version 18.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
 0:02.83 INFO Checking for ssltunnel processes...
 0:02.89 INFO Checking for xpcshell processes...
 0:02.95 SUITE_START: mochitest-plain - running 1 tests
 0:02.95 INFO Running manifest: dom\media\test\mochitest.ini
c:\Projects\mozilla-builds\obj-ff-dbg-opt\dist\bin\pk12util.exe: PKCS12 IMPORT SUCCESSFUL
 0:04.04 INFO MochitestServer : launching [u'c:\\Projects\\mozilla-builds\\obj-ff-dbg-opt\\dist\\bin\\xpcshell.exe', '-g', u'c:\\Projects\\mozilla-builds\\obj-ff-dbg-opt\\dist\\bin', '-f', u'c:\\Projects\\mozilla-builds\\obj-ff-dbg-opt\\dist\\bin\\components\\httpd.js', '-e', "const _PROFILE_PATH = 'c:\\\\users\\\\brycev~1\\\\appdata\\\\local\\\\temp\\\\tmpa4dcv0.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = true;", '-f', 'c:\\Projects\\mozilla-builds\\obj-ff-dbg-opt\\_tests\\testing\\mochitest\\server.js']
 0:04.04 INFO runtests.py | Server pid: 15172
 0:04.04 INFO runtests.py | Websocket server pid: 10612
 0:04.05 INFO runtests.py | websocket/process bridge pid: 13292
Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[15172, Main Thread] WARNING: Failed to get directory to cache.: file c:/Projects/mozilla-central/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 80
[15172, Main Thread] WARNING: Failed to get directory to cache.: file c:/Projects/mozilla-central/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 80
[15172, Main Thread] WARNING: Failed to get directory to cache.: file c:/Projects/mozilla-central/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 80
[15172, Main Thread] WARNING: Failed to get directory to cache.: file c:/Projects/mozilla-central/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 80
[15172, Main Thread] WARNING: Failed to get directory to cache.: file c:/Projects/mozilla-central/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp, line 80
[15172, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file c:/Projects/mozilla-central/dom/media/CubebUtils.cpp, line 358
Traceback (most recent call last):
  File "websocketprocessbridge\websocketprocessbridge.py", line 9, in <module>
    import psutil
  File "c:\Projects\mozilla-central\build\mach_bootstrap.py", line 386, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "c:\Projects\mozilla-central\third_party\python\psutil-cp27-none-win_amd64\psutil\__init__.py", line 146, in <module>
    from . import _pswindows as _psplatform
  File "c:\Projects\mozilla-central\build\mach_bootstrap.py", line 386, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "c:\Projects\mozilla-central\third_party\python\psutil-cp27-none-win_amd64\psutil\_pswindows.py", line 16, in <module>
    from . import _psutil_windows as cext
  File "c:\Projects\mozilla-central\build\mach_bootstrap.py", line 386, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
ImportError: DLL load failed: %1 is not a valid Win32 application.
 1:53.17 ERROR runtests.py | Timed out while waiting for websocket/process bridge startup.
 1:53.19 INFO runtests.py | SSL tunnel pid: 23348
 1:53.19 INFO runtests.py | Running with scheme: http
 1:53.19 INFO runtests.py | Running with e10s: True
 1:53.19 INFO runtests.py | Running with serviceworker_e10s: False
 1:53.19 INFO runtests.py | Running tests: start.
<Normal test output follows>

Comment 1

[(not currently active) Ted Mielczarek]

It's failing to import psutil, and apparently this is because I screwed up landing the patch for bug 1481612 somehow. :-/

$ ls -l third_party/python/psutil-cp27-none-win_amd64/psutil/_psutil_windows.pyd
-rw-r--r-- 1 ted Administrators 0 Oct 11 10:47 third_party/python/psutil-cp27-none-win_amd64/psutil/_psutil_windows.pyd

That file should not be zero bytes!

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #1)

It's failing to import psutil, and apparently this is because I screwed up landing the patch for bug 1481612 somehow. :-/

$ ls -l third_party/python/psutil-cp27-none-win_amd64/psutil/_psutil_windows.pyd
-rw-r--r-- 1 ted Administrators 0 Oct 11 10:47 third_party/python/psutil-cp27-none-win_amd64/psutil/_psutil_windows.pyd

That file should not be zero bytes!

Sounds like you've already got a good handle on this, but confirming that I see the same.

Comment 3

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7550a6776edd6fd4628678cce2523bcb2400b0a9
bug 1518842 - fix badly-landed binary patch from bug 1481612. r=me

Comment 4

[(not currently active) Ted Mielczarek]

I landed a fixup patch that simply corrected the file. I think it must have been broken when I re-landed the patch after it getting backed out. This should fix the issue.

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7550a6776edd

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Thanks for the quick diagnosis and fix! Verified that the issue is no longer present on today's pull.