1518951 - Remove trackingMode from SecurityInformation

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Eugen Sawin [:esawin]]

See bug 1514340, we can no longer easily support the aggregated tracking mode status and we have dedicated tracking protection / content blocking APIs that cover this information sufficiently.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: Bug 1518951 - [1.0] Remove redundant trackingMode field from SecurityInformation. r=snorp,droeh

Comment 2

[(no longer active)]

Hi Eugen, I made a try push with my patches and yours. There are still gv-junit1 and mochitest as well as a new apilint failure on the try push.

Please see https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9242c500e3004b723feb98d9c8e0997f58a017b.

Thanks!

Comment 3

[Eugen Sawin [:esawin]]

The mochitest should be part of the Fennec fix, the apilint error just means I need to update CHANGELOG.md before landing my patch.

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

Comment 4

[(no longer active)]

(In reply to Eugen Sawin [:esawin] from comment #3)

The mochitest should be part of the Fennec fix

Great!

the apilint error just means I need to update CHANGELOG.md before landing my patch.

Oh maybe that's my fault then, cause I got a merge failure on that file and thought it's not important...

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

I would appreciate that. Is that related to this patch in any way, or are those failure unrelated to this one?

Comment 5

[Eugen Sawin [:esawin]]

(In reply to :Ehsan Akhgari from comment #4)

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

I would appreciate that. Is that related to this patch in any way, or are those failure unrelated to this one?

The issue is that we're missing the matchedList attribute in GeckoViewTrackingProtection.onContentBlockingEvent which is set in the onSecurityChange case with your changes.

Comment 6

[Eugen Sawin [:esawin]]

Attachment: Bug 1518951 - [1.1] Remove redundant trackingMode field from SecurityInformation. r=snorp,droeh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcb9d90e5456
[1.1] Remove redundant trackingMode field from SecurityInformation.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dcb9d90e5456

Comment 9

[(no longer active)]

(In reply to Eugen Sawin [:esawin] from comment #5)

(In reply to :Ehsan Akhgari from comment #4)

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

I would appreciate that. Is that related to this patch in any way, or are those failure unrelated to this one?

The issue is that we're missing the matchedList attribute in GeckoViewTrackingProtection.onContentBlockingEvent which is set in the onSecurityChange case with your changes.

Thanks for this hint, fixing this issue addressed that test failure!

Comment 10

[Chris Peterson [:cpeterson]]

Eugen, do we need to uplift this fix to GV 65 Beta for the Focus 9.0's ad blocking experiment?

Comment 11

[Eugen Sawin [:esawin]]

(In reply to Chris Peterson [:cpeterson] from comment #10)

Eugen, do we need to uplift this fix to GV 65 Beta for the Focus 9.0's ad blocking experiment?

No, this is unrelated and should ride trains on 66.

Comment 12

[Chris Peterson [:cpeterson]]

Thanks.

65=wontfix