Remove trackingMode from SecurityInformation

RESOLVED FIXED in Firefox 66

Status

enhancement
P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: esawin, Assigned: esawin)

Tracking

Trunk
mozilla66
All
Android

Firefox Tracking Flags

(geckoview64 wontfix, geckoview65 wontfix, geckoview66 fixed, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 months ago

See bug 1514340, we can no longer easily support the aggregated tracking mode status and we have dedicated tracking protection / content blocking APIs that cover this information sufficiently.

Status: NEW → ASSIGNED
Priority: -- → P1

Hi Eugen, I made a try push with my patches and yours. There are still gv-junit1 and mochitest as well as a new apilint failure on the try push.

Please see https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9242c500e3004b723feb98d9c8e0997f58a017b.

Thanks!

(Assignee)

Comment 3

4 months ago

The mochitest should be part of the Fennec fix, the apilint error just means I need to update CHANGELOG.md before landing my patch.

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

(In reply to Eugen Sawin [:esawin] from comment #3)

The mochitest should be part of the Fennec fix

Great!

the apilint error just means I need to update CHANGELOG.md before landing my patch.

Oh maybe that's my fault then, cause I got a merge failure on that file and thought it's not important...

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

I would appreciate that. Is that related to this patch in any way, or are those failure unrelated to this one?

(Assignee)

Comment 5

4 months ago

(In reply to :Ehsan Akhgari from comment #4)

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

I would appreciate that. Is that related to this patch in any way, or are those failure unrelated to this one?

The issue is that we're missing the matchedList attribute in GeckoViewTrackingProtection.onContentBlockingEvent which is set in the onSecurityChange case with your changes.

Attachment #9036059 - Attachment is obsolete: true
Attachment #9036059 - Attachment is obsolete: false

Comment 7

4 months ago
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcb9d90e5456
[1.1] Remove redundant trackingMode field from SecurityInformation.

Comment 8

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Attachment #9035481 - Attachment is obsolete: true

(In reply to Eugen Sawin [:esawin] from comment #5)

(In reply to :Ehsan Akhgari from comment #4)

gv-junit1 is however related to your changes, it means the new events are not going through GeckoView correctly, which is why the test is timing out.
I can help with troubleshooting on a local build with your patches.

I would appreciate that. Is that related to this patch in any way, or are those failure unrelated to this one?

The issue is that we're missing the matchedList attribute in GeckoViewTrackingProtection.onContentBlockingEvent which is set in the onSecurityChange case with your changes.

Thanks for this hint, fixing this issue addressed that test failure!

Eugen, do we need to uplift this fix to GV 65 Beta for the Focus 9.0's ad blocking experiment?

Flags: needinfo?(esawin)
(Assignee)

Comment 11

4 months ago

(In reply to Chris Peterson [:cpeterson] from comment #10)

Eugen, do we need to uplift this fix to GV 65 Beta for the Focus 9.0's ad blocking experiment?

No, this is unrelated and should ride trains on 66.

Flags: needinfo?(esawin)
You need to log in before you can comment on or make changes to this bug.