Closed
Bug 1518961
Opened 5 years ago
Closed 5 years ago
Show evaluated frames when pausing on exceptions
Categories
(DevTools :: Debugger, enhancement, P2)
DevTools
Debugger
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
5.68 KB,
patch
|
loganfsmyth
:
review+
|
Details | Diff | Splinter Review |
Bug 1448431 prevents the debugger from pausing on exceptions thrown while doing client evaluations from the console or watched expressions, but in doing so we are also unable to pause in all evaluated frames, including those entirely local to the debuggee. Also see the associated URL for how this can lead to weird debugger behavior.
The attached patch fixes this by changing the mechanism added by bug 1448431. Instead of ignoring exceptions thrown by scripts missing URLs (including both client and debuggee eval scripts), we set a flag on the thread actor while doing a client evaluation which causes it to ignore all exceptions.
Attachment #9035493 -
Flags: review?(lsmyth)
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → bhackett1024
|
||
Updated•5 years ago
|
Priority: -- → P2
|
||
Updated•5 years ago
|
Attachment #9035493 -
Flags: review?(lsmyth) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe6548db11d Show evaluated frames when pausing on exceptions, r=lsmyth.
|
||
Comment 2•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•