Closed Bug 1518961 Opened 9 months ago Closed 9 months ago

Show evaluated frames when pausing on exceptions

Categories

(DevTools :: Debugger, enhancement, P2)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Attached patch patchSplinter Review

Bug 1448431 prevents the debugger from pausing on exceptions thrown while doing client evaluations from the console or watched expressions, but in doing so we are also unable to pause in all evaluated frames, including those entirely local to the debuggee. Also see the associated URL for how this can lead to weird debugger behavior.

The attached patch fixes this by changing the mechanism added by bug 1448431. Instead of ignoring exceptions thrown by scripts missing URLs (including both client and debuggee eval scripts), we set a flag on the thread actor while doing a client evaluation which causes it to ignore all exceptions.

Attachment #9035493 - Flags: review?(lsmyth)
Assignee: nobody → bhackett1024
Priority: -- → P2
Attachment #9035493 - Flags: review?(lsmyth) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbe6548db11d
Show evaluated frames when pausing on exceptions, r=lsmyth.
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.