1518962 - cmd + f in youtube.com attempts fullscreen (and then bails), rather than bringing up a search dialog

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Mike Taylor [:miketaylr]]

STR:

1. navigate to https://www.youtube.com/watch?v=g4mHPeMGTJM
2. hit cmd+f (to search for something in the comments

Expected:

search pane appears on bottom of window

Actual:

fullscreen is entered, then exited (displaying only black)

Note: the Youtube shortcut for fullscreen, which works is just "f".

Comment 1

[Mike Taylor [:miketaylr]]

Masayuki, would cmd+f have been covered by Bug 1203059? Or did we somehow regress this before 64? Thanks.

Comment 2

[Francesco Lodolo [:flod]]

There is also bug 1518827, which claims the opposite (cmd+F should go full screen). Are both symptoms of some changes on YouTube's side?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Mike Taylor [:miketaylr] from comment #1)

Masayuki, would cmd+f have been covered by Bug 1203059? Or did we somehow regress this before 64? Thanks.

Is the bug number correct? I don't think that this is not related to bug 1203059 because Cmd+F is not a reserved shortcut key by default (IIRC).

This is reproducible with Nightly for macOS too, but I cannot reproduce this with Nightly for Windows nor Firefox 64 for Windows. So, I guess that this is simply a their bug.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: "keydown" event for both "f" and "cmd+f" are same except modifier state of "Meta". This is expected result.

Comment 5

[Mike Taylor [:miketaylr]]

Cmd+F is not a reserved shortcut key by default

Yeah, I wasn't sure if this was the case or not.

I'll send an email to YouTube and ask that they check for meta before attempting to go fullscreen.

Comment 6

[Mike Taylor [:miketaylr]]

Email sent.

Comment 8

[Mike Taylor [:miketaylr]]

Update from YouTube ⚡:

We heard several reports and reverted the breaking change ASAP. With luck, it'll be fixed in the next release (ETA tomorrow morning).

Comment 9

[:Gijs (he/him)]

(In reply to Mike Taylor [:miketaylr] from comment #5)

Cmd+F is not a reserved shortcut key by default

Yeah, I wasn't sure if this was the case or not.

Out of curiosity, I know Chrome has reserved keys as well - do they reserve accel-f , and would that have avoided our bug here, or is this an issue with what code they're serving Firefox? Obviously, we can't fix this in-product anywhere near as fast as youtube can, but perhaps we should consider making accel-f reserved if that's what Chrome do.

Comment 10

[Mike Taylor [:miketaylr]]

Chrome's behavior matches ours here on YouTube -- they go to fullscreen instead of showing the search widget (but sometimes it appears after going fullscreen? It seems racey).

Comment 11

[Swarnava Sengupta (:Swarnava)]

It seems fixed now. 🥳