1518991 - Make nsIPrincipal URI getter infallible

Status: RESOLVED FIXED

(Core :: Security: CAPS, enhancement, P3)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Getting a URI from a principal is an infallible operation. We may get back a nullptr, but the getter always returns NS_OK. We could clean up some C++ code by removing the success checks.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1518991 - Make nsIPrincipal URI getter infallible;

nsIPrincipal::GetURI returns NS_OK for all implementations. Make it
infallible so we can clean up status checks in C++ code that uses principals.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e654e9222bd
Make nsIPrincipal URI getter infallible; r=bholley

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4e654e9222bd