1518996 - textarea / text box for proxy exceptions in preferences' networking dialog has double border when focused

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[slanterns.w]

Attachment: Snipaste_2019-01-10_11-35-46.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Open about:preferences#general

Actual results:

The input box looks strange.

Expected results:

The input box looks normal.

Comment 1

[Tim Nguyen :ntim]

textbox[multiline] has an inner textarea, which makes both the xul|textbox and html|textarea rules apply at the same time.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See How Do You Triage for more information

Comment 3

[:Gijs (he/him)]

(In reply to Tim Nguyen :ntim from comment #1)

textbox[multiline] has an inner textarea, which makes both the xul|textbox and html|textarea rules apply at the same time.

Thanks for this. Seeing as I'm looking at this border/outline stuff anyway, I'll see if I can do something here, too.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r?dao,jaws

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a30f1b817c
fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r=jaws

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/92a30f1b817c

Comment 7

[:Gijs (he/him)]

Comment on attachment 9035976 [details]
Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r?dao,jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1502684

User impact if declined: Strange focus outline on text area in about:preferences

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Check visual appearance of this element in network prefs across OSes

List of other uplifts needed: n/a

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): CSS-only change specifically to fix this. Can't really see much going wrong here.

String changes made/needed: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9035976 [details]
Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r?dao,jaws

[Triage Comment]
Fix for strange focus outline in about:preferences. Approved for 65.0b11.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/76325782999f

Comment 10

[Mihai Boldan, Desktop QA [:mboldan]]

Managed to reproduce this issue on Firefox 66.0a1 (2019-01-08), under Windows 10x64.
This issue is no longer reproducible on Firefox 65.0b11, or on Firefox 66.0a1 (2019-01-14).
Tests were executed under Windows 7x86, Windows 10x64, macOS 10.12.6 and under Ubuntu 16.04x64.
Marking this issue Verified Fixed.