textarea / text box for proxy exceptions in preferences' networking dialog has double border when focused

VERIFIED FIXED in Firefox 65

Status

()

defect
P1
normal
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: slanterns.w, Assigned: Gijs)

Tracking

({regression})

66 Branch
mozilla66
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65+ verified, firefox66+ verified)

Details

Attachments

(2 attachments)

Reporter

Description

5 months ago

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Open about:preferences#general

Actual results:

The input box looks strange.

Expected results:

The input box looks normal.

Reporter

Updated

5 months ago
Component: Untriaged → Preferences
OS: Unspecified → Windows 7
Hardware: Unspecified → x86
Blocks: 1502684
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(ntim.bugs)
Keywords: regression
Priority: -- → P3

Comment 1

5 months ago

textbox[multiline] has an inner textarea, which makes both the xul|textbox and html|textarea rules apply at the same time.

Flags: needinfo?(ntim.bugs)

Updated

5 months ago
Component: Preferences → Themes
Product: Firefox → Toolkit

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See How Do You Triage for more information

Priority: P3 → P1
Assignee

Comment 3

4 months ago

(In reply to Tim Nguyen :ntim from comment #1)

textbox[multiline] has an inner textarea, which makes both the xul|textbox and html|textarea rules apply at the same time.

Thanks for this. Seeing as I'm looking at this border/outline stuff anyway, I'll see if I can do something here, too.

Assignee

Updated

4 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

Comment 5

4 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92a30f1b817c
fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r=jaws

Comment 6

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee

Comment 7

4 months ago

Comment on attachment 9035976 [details]
Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r?dao,jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1502684

User impact if declined: Strange focus outline on text area in about:preferences

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Check visual appearance of this element in network prefs across OSes

List of other uplifts needed: n/a

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): CSS-only change specifically to fix this. Can't really see much going wrong here.

String changes made/needed: None

Attachment #9035976 - Flags: approval-mozilla-beta?
Assignee

Updated

4 months ago
Summary: preferences input box looks strange → textarea / text box for proxy exceptions in preferences' networking dialog has double border when focused
Flags: qe-verify+

Comment on attachment 9035976 [details]
Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r?dao,jaws

[Triage Comment]
Fix for strange focus outline in about:preferences. Approved for 65.0b11.

Attachment #9035976 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Managed to reproduce this issue on Firefox 66.0a1 (2019-01-08), under Windows 10x64.
This issue is no longer reproducible on Firefox 65.0b11, or on Firefox 66.0a1 (2019-01-14).
Tests were executed under Windows 7x86, Windows 10x64, macOS 10.12.6 and under Ubuntu 16.04x64.
Marking this issue Verified Fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.