Consider to tun on MOZ_LIBAV_FFT on android/aarch64
Categories
(Core :: Web Audio, enhancement, P2)
Tracking
()
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 4 obsolete files)
(In reply to Karl Tomlinson (:karlt) from bug 1518994 comment #3)
ffmpeg has aarch64 assembly for FFTs. We'd need to import fft_init_aarch64.c and fft_neon.S from libavcodec/aarch64 into ffvpx, similarly to some of what was done in bug 1476231.
Also, FLAC in libavcodec doesn't have aarch64's assembler, but libavutil also has aarch64 assembler.
Assignee | ||
Comment 1•6 years ago
|
||
- No additional ASFLAG for aarch64 build to use assembler of ffmpeg
- We need add files into avutils/aarch64 too.
- We won't need VP8/VP9 for android. Android has platform decoder. FLAC + FFT only.
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Import aarch64 files from n4.0.2 tag
Assignee | ||
Comment 4•6 years ago
|
||
Add generated config.h that is generated by Ubuntu 18.04/aarch64.
Depends on D18044
Assignee | ||
Comment 5•6 years ago
|
||
Add moz.build files and modify some files to build for aarch64.
Depends on D18045
Assignee | ||
Comment 6•6 years ago
|
||
ffvpx uses FFVPX_ASFLAGS flags to build cpu specific code, so I
add -march=armv8-a like libjpeg-turbo's build option.
Also, LIBAV_FF is same.
Depends on D18046
Comment 7•6 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:m_kato, could you have a look please?
Comment 8•5 years ago
|
||
Was this ever ready to land? Maybe I can finish it up?
Assignee | ||
Comment 9•5 years ago
|
||
I need rebase this then re-review this since this is old patch.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 10•2 years ago
|
||
"Convolution reverb" of https://padenot.github.io/webaudio-benchmark/ improves
from 8x to 14x on Android/aarch64.
Also, Android/x86 improves from 19x to 21x.
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
bugherder |
Comment 13•2 years ago
|
||
Since this patch uses assembler code we haven't tested on Android before, it should probably ride the trains with 113 (and not be uplifted to Beta 112).
Description
•