1519004 - Consider to tun on MOZ_LIBAV_FFT on android/aarch64

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P2)

Description

[Makoto Kato [:m_kato]]

(In reply to Karl Tomlinson (:karlt) from bug 1518994 comment #3)

ffmpeg has aarch64 assembly for FFTs. We'd need to import fft_init_aarch64.c and fft_neon.S from libavcodec/aarch64 into ffvpx, similarly to some of what was done in bug 1476231.

Also, FLAC in libavcodec doesn't have aarch64's assembler, but libavutil also has aarch64 assembler.

Comment 1

[Makoto Kato [:m_kato]]

• No additional ASFLAG for aarch64 build to use assembler of ffmpeg
• We need add files into avutils/aarch64 too.
• We won't need VP8/VP9 for android. Android has platform decoder. FLAC + FFT only.

Comment 2

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecff4be5fe140b9ab8bedf297361dcaeeeccbebf

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1519004 - Part 1. Add ffvpx aarch64 files to tree

Import aarch64 files from n4.0.2 tag

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1519004 - Part 2. Add config_unix_aarch64.h for Linux/Android aarch64 build

Add generated config.h that is generated by Ubuntu 18.04/aarch64.

Depends on D18044

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1519004 - Part 3. Allow to build ffvpx for aarch64.

Add moz.build files and modify some files to build for aarch64.

Depends on D18045

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1519004 - Part 4. Modify moz.configure to build ffvpx

ffvpx uses FFVPX_ASFLAGS flags to build cpu specific code, so I
add -march=armv8-a like libjpeg-turbo's build option.

Also, LIBAV_FF is same.

Depends on D18046

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:m_kato, could you have a look please?

Comment 8

[Paul Adenot (:padenot)]

Was this ever ready to land? Maybe I can finish it up?

Comment 9

[Makoto Kato [:m_kato]]

I need rebase this then re-review this since this is old patch.

Comment 10

[Makoto Kato [:m_kato]]

Attachment: Bug 1519004 - Use MOZ_LIBAV_FFT on Android if not arm32. r=padenot

"Convolution reverb" of https://padenot.github.io/webaudio-benchmark/ improves
from 8x to 14x on Android/aarch64.

Also, Android/x86 improves from 19x to 21x.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/130fdbc14ed3
Use MOZ_LIBAV_FFT on Android if not arm32. r=padenot

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/130fdbc14ed3

Comment 13

[Chris Peterson [:cpeterson]]

Since this patch uses assembler code we haven't tested on Android before, it should probably ride the trains with 113 (and not be uplifted to Beta 112).