Closed Bug 1519019 Opened 1 year ago Closed 1 year ago

Uplift fix to CallStack Group with anonymous function

Categories

(DevTools :: Debugger, defect, P1)

65 Branch
defect

Tracking

(firefox65 fixed, firefox66 fixed)

RESOLVED FIXED
Firefox 66
Tracking Status
firefox65 --- fixed
firefox66 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

The fix landed as part of Bug 1517572 (rd3524cb549ec).
We can't directly request an uplift directly since there are other commits in that patch, so let's do it here.

This is the same patch as in Bug 1517572, applied on the beta branch.

Comment on attachment 9035551 [details]
Bug 1519019 - Uplift fix to CallStack Group with anonymous function. r=jlast;

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Debugger may crash if paused at a breakpoint where the last frame inside a framework is an anonymous function

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a small change, landed for some time on Nightly already, with a mochitest.

String changes made/needed:

Attachment #9035551 - Flags: approval-mozilla-beta?
Flags: qe-verify-
Flags: in-testsuite+
Target Milestone: --- → Firefox 66
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Comment on attachment 9035551 [details]
Bug 1519019 - Uplift fix to CallStack Group with anonymous function. r=jlast;

[Triage Comment]
Fixes a debugger crash and includes an automated test. Approved for 65.0b12.

Attachment #9035551 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.