Closed Bug 1519053 Opened 5 years ago Closed 5 years ago

Set window handle for "Switch To Window" also as "handle"

Categories

(Testing :: geckodriver, enhancement, P3)

Product:
Testing
Component:
geckodriver
Type:
enhancement

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: whimboo, Assigned: kritisingh1.ks, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=rs])

User Story

To get started follow the documentation at:

https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html

https://firefox-source-docs.mozilla.org/testing/geckodriver/geckodriver/index.html

Attachments

(1 file, 2 obsolete files)

Bug 1519053 - Set window handle for 'Switch To Window' also as 'handle'. r=whimboo
47 bytes, text/x-phabricator-request
Details | Review

To get started on bug 1301073 we have to make geckodriver backward compatible by also setting the window handle as "handle" here:

https://searchfox.org/mozilla-central/rev/5053031ba7621fa8f63f42de4c204ab3561e4e59/testing/geckodriver/src/marionette.rs#1447

The "name" property should be left-in for now to stay compatible.

Priority: -- → P3

Hi Henrik I would like to work on it , I build the firefox locally on my laptop. Can you guide me how to go ahead with it?

Thanks

Flags: needinfo?(hskupin)

As comment 0 explains just add handle next to name as member of the data instance.

Flags: needinfo?(hskupin)
Assignee: nobody → shivams2799

Hi I would like to take this up if its not active. Please let me know if I may. Thanks!

Kriti , I am working on it , had a rough last week sorry.

Thanks

Status: NEW → ASSIGNED

Just to let you know we basically assign bugs to the first one who uploads a patch. So please upload one, or other might/will do it in the next days.

Assignee: shivams2799 → nobody
Status: ASSIGNED → NEW
Assignee: nobody → kritisingh1.ks
Blocks: 1520585
Status: NEW → ASSIGNED
Attachment #9050352 - Attachment is obsolete: true
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44fee8919949
Set window handle for 'Switch To Window' also as 'handle'. r=whimboo

https://hg.mozilla.org/mozilla-central/rev/44fee8919949

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Blocks: 1588424
Attachment #9050284 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: