1519106 - Increase the max number of rasterized blobs per transaction

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Nicolas Silva [:nical]]

See https://github.com/servo/webrender/issues/3496

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1519106 - Increase the maximum number of rasterized blob images per transaction. r=kats

Comment 2

[Nicolas Silva [:nical]]

Talos run https://treeherder.mozilla.org/#/jobs?repo=try&revision=88efc000e1d92a77e3e2a7a9bae3b7f33552e651

Comment 3

[Nicolas Silva [:nical]]

There's some notable perf difference, good and bad. I am a tad surprised by the tp5o_scroll regression. Could be because we end up eagerly rasterizing tiles that we don't scroll to.

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=88efc000e1d92a77e3e2a7a9bae3b7f33552e651&framework=1&showOnlyConfident=1&selectedTimeRange=172800

Comment 4

[Jeff Muizelaar [:jrmuizel]]

What ended up being the results of kats suggestions about the loop and talos regressions?

Comment 5

[Sotaro Ikeda [:sotaro]]

One side effect of attachment 9035629 [details] is that checkerboarding of STR of Bug 1494164 comment 0 became significant.
https://static.mozilla.com/moco/en-US/images/mozilla_eoy_2013_EN.svg

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Just to clarify this patch makes the checkboarding of mozilla_eoy_2013_EN.svg worse?

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)

Just to clarify this patch makes the checkboarding of mozilla_eoy_2013_EN.svg worse?

Yes, with the patch, I saw longer white content(mozilla_eoy_2013_EN.svg) during scrolling on P50(Win10).

Comment 8

[Nicolas Silva [:nical]]

What ended up being the results of kats suggestions about the loop and talos regressions?

I forgot about that. It's completely orthogonal to the patch FWIW and I'm more worried about the extra checkerboarding reported by Sotaro.

There has to be a good tradeoff to pick between checkerboarding and jank but it needs some experimentation.

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 1519106 - Converge towards the max number of tiles faster. r=jrmuizel

Comment 10

[Nicolas Silva [:nical]]

Attachment: Bug 1519106 - Converge towards the max number of tiles faster. r=kats

Comment 11

[Nicolas Silva [:nical]]

Attachment: Bug 1519106 - Converge towards the max number of tiles faster. r=kats

Comment 12

[Nicolas Silva [:nical]]

Attachment: Bug 1519106 - Converge towards the max number of tiles faster. r=kats

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6c9841c74cd
Increase the maximum number of rasterized blob images per transaction. r=kats
https://hg.mozilla.org/integration/autoland/rev/902bff64318d
Converge towards the max number of tiles faster. r=kats

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d6c9841c74cd
https://hg.mozilla.org/mozilla-central/rev/902bff64318d