Increase the max number of rasterized blobs per transaction

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
7 months ago
Last month

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments, 3 obsolete attachments)

There's some notable perf difference, good and bad. I am a tad surprised by the tp5o_scroll regression. Could be because we end up eagerly rasterizing tiles that we don't scroll to.

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=88efc000e1d92a77e3e2a7a9bae3b7f33552e651&framework=1&showOnlyConfident=1&selectedTimeRange=172800

What ended up being the results of kats suggestions about the loop and talos regressions?

Flags: needinfo?(nical.bugzilla)

Just to clarify this patch makes the checkboarding of mozilla_eoy_2013_EN.svg worse?

Flags: needinfo?(sotaro.ikeda.g)

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)

Just to clarify this patch makes the checkboarding of mozilla_eoy_2013_EN.svg worse?

Yes, with the patch, I saw longer white content(mozilla_eoy_2013_EN.svg) during scrolling on P50(Win10).

Flags: needinfo?(sotaro.ikeda.g)

What ended up being the results of kats suggestions about the loop and talos regressions?

I forgot about that. It's completely orthogonal to the patch FWIW and I'm more worried about the extra checkerboarding reported by Sotaro.

There has to be a good tradeoff to pick between checkerboarding and jank but it needs some experimentation.

Flags: needinfo?(nical.bugzilla)
Attachment #9035629 - Attachment description: Bug 1519106 - Increase the maximum number of rasterized blob images per transaction. r=jrmuizel → Bug 1519106 - Increase the maximum number of rasterized blob images per transaction. r=kats
Attachment #9058507 - Attachment is obsolete: true
Attachment #9058883 - Attachment is obsolete: true
Attachment #9058879 - Attachment is obsolete: true
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6c9841c74cd
Increase the maximum number of rasterized blob images per transaction. r=kats
https://hg.mozilla.org/integration/autoland/rev/902bff64318d
Converge towards the max number of tiles faster. r=kats
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.