Port Bug 1454357 Remove scrollbox binding

RESOLVED FIXED in 6.8

Status

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

Trunk

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

After fixing the massive failure in bug 1519078, we're left with some MozMill Calendar failures:

https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=cb009c395002e0a6bfbfa429448f6036c3ea6f2e

I've run
mozmake -C comm/calendar/test/mozmill SOLO_TEST=testTodayPane.js mozmill-one

I see

JavaScript error: chrome://calendar/content/calendar-multiday-view.xml, line 2532: TypeError: document.getAnonymousElementByAttribute(...) is null

And that code is:

  let scrollbox = document.getAnonymousElementByAttribute(
                 this, "anonid", "scrollbox");
  document.getAnonymousElementByAttribute(
      scrollbox, "class", "box-inherit scrollbox-innerbox").flex = "1";
Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Flags: needinfo?(arshdkhn1)
Assignee

Comment 1

5 months ago

This fixes the calendar issue for me. Without patch, opening the event tab makes TB very, very wide (around 3400px). With patch the views in the event tab look like they should.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)
Flags: needinfo?(arshdkhn1)
Attachment #9035671 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9035671 [details] [diff] [review]
1519114-no-scrollbox-innerbox.patch

Review of attachment 9035671 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thx Richard! r=mkmelin
Attachment #9035671 - Flags: review?(mkmelin+mozilla) → review+
Assignee

Comment 3

5 months ago

I checked also that this was our only occurrence of scrollbox-innerbox in the tree.

Keywords: checkin-needed

Comment 4

5 months ago

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/98ce18ce0ea7
Port Bug 1454357 Remove scrollbox binding. r=mkmelin

Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.8
You need to log in before you can comment on or make changes to this bug.