1519141 - [Search hand-off ] "Esc" should make the in-content search re-appear.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Mehmet]

Nightly 66.0a1 (2019-01-10) (64-Bit)
OS=All Desktop

STR:

1.) Navigate to the NTP
2.) Focus the In-Content Search Bar
3.) Type something, so that the In-Content Search Bar disappears and the Drop Down of the Address Bar appears
4.) Press (2-times) the ESC Key to reset the typed search string

Actual: In-Content Search Bar does not re-appear.

Expected: Focus should stay in the Addressbar, but the In-Content Search Bar should re-appear.

Please compare the behavior in Google Chrome and see the comments 31-34 in bug 1508388.

Thanks :)

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4668

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/fd1472d5e02663a58d6632541c75d2387fde46b9
Bug 1519141 - "Esc" should make the in-content search re-appear. (#4668)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/25af8129d9f2

Comment 4

[Mehmet]

Great, thank you for fixing this :)

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly 66.0a1 (Build ID 20190120213632) on Windows 10 x64, Mac OS 10.13.3, and Arch Linux 4.14. Pressing ESC makes the in-content search bar reappear.