1519164 - Prefs for Content Blocking UI Tour in 65

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Betsy Mikel [:betsymi]]

The UI tours live behind a pref. A new pref needs to be uplifted so that 65 Release users are served the correct tour. To do this, Johann needs the exact URLs.

Comment 1

[Alex Gibson [:agibson]]

This just made it to production:

Normal window:

• https://www.mozilla.org/en-US/firefox/65.0/content-blocking/start/?newtab=true
• https://www.mozilla.org/en-US/firefox/65.0/content-blocking/start/?newtab=true&variation=2

Private Window:

• https://www.mozilla.org/en-US/firefox/65.0/content-blocking/start/
• https://www.mozilla.org/en-US/firefox/65.0/content-blocking/start/?variation=2

Comment 2

[Betsy Mikel [:betsymi]]

Great! Thank you.

Comment 3

[Johann Hofmann [:johannh]]

[Tracking Requested - why for this release]:
New URLs for content blocking tour (just a pref update)

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1519164 - Update content blocking UI tour url. r=nhnt11

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/939479cc5903
Update content blocking UI tour url. r=nhnt11

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/939479cc5903

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 9035876 [details]
Bug 1519164 - Update content blocking UI tour url. r=nhnt11

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Content blocking UI tour URL isn't up to date (we might do changes on the new version only)

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Try to open the content blocking tour through different means, e.g. on first use or on about:privatebrowsing. It should still work, but the url should contain "content-blocking" instead of "tracking-protection"

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Simple pref update

String changes made/needed: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9035876 [details]
Bug 1519164 - Update content blocking UI tour url. r=nhnt11

[Triage Comment]
Ensures that the Content Blocking UI tour URL is up to date. Approved for 65.0b11.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7448d41d4fdc

Comment 11

[Vlad Lucaci, Desktop QA (:vlucaci)]

I have verified that the Content Blocking UI tour is correctly displayed in normal/private browsing and the URL contains the "content-blocking" string. Tested on latest Nightly 66.0a1 and Beta 65.0b11 across OSes: Win 10 x64, macOS 10.13 and Ubuntu 16.04 x86.