Add a shadow-including tree iterator

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(5 attachments)

This is coming up in various places in specs, and it would be nice if people didn't have to keep reimplementing it.

Assignee: nobody → bzbarsky

Comment 6

5 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aae6e06aa88b
part 1.  Add an iterator that implements "shadow-including tree order" traversal.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/1caa462e7f08
part 2.  Convert CandidateFinder::Traverse to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/08b0f2b9a96a
part 3.  Convert CustomElementRegistry::Upgrade to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/12d89a7fe296
part 4.  Convert AssertNoFramesInSubtree to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/e118466df64d
part 5.  Convert AssertNoStaleServoDataIn to using ShadowIncludingTreeIterator.  r=emilio

Gah, unified builds. It built locally and on try, multiple times.... Ah, well.

Flags: needinfo?(bzbarsky)

Comment 9

5 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a5956b8ebdf
part 1.  Add an iterator that implements "shadow-including tree order" traversal.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/9edfd05acd77
part 2.  Convert CandidateFinder::Traverse to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/4a2c6e288944
part 3.  Convert CustomElementRegistry::Upgrade to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/a61568f1b081
part 4.  Convert AssertNoFramesInSubtree to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/47920e0b9643
part 5.  Convert AssertNoStaleServoDataIn to using ShadowIncludingTreeIterator.  r=emilio
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.