Closed Bug 1519231 Opened 3 years ago Closed 3 years ago

Stop building nsssysinit for Firefox

Categories

(NSS :: Build, enhancement)

All
Linux
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mt, Assigned: mt)

References

Details

Attachments

(1 file)

In Bug 818686 we noticed that nsssysinit.so was being built in gyp builds [1]. This it not built when MOZILLA_CLIENT was set in make builds [2].

Given that we don't use the default database location in Firefox AND the code works fine without nsssysinit [3], I think that we can stop building and linking this. It's not big, but every bit counts.

[1] gyp: https://searchfox.org/nss/rev/7fcf00883fb4d25a1bd085c824489c405b98666a/nss.gyp#32
[2] make: https://searchfox.org/nss/rev/7fcf00883fb4d25a1bd085c824489c405b98666a/lib/Makefile#39-43
[3] https://searchfox.org/nss/rev/7fcf00883fb4d25a1bd085c824489c405b98666a/lib/pk11wrap/pk11load.c#467-472

Ted, you did the original port. Would you agree with this assessment?

Flags: needinfo?(ted)
This disables building of nsssysinit in gecko builds.  This code isn't used by
Firefox and we could use less code.

Nice catch! It does indeed sound sensible. The original gyp files were somewhat auto-generated by evaluating the Makefiles. While I did compare results it's likely that some nuance was lost.

Flags: needinfo?(ted)
Assignee: nobody → martin.thomson
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.43
You need to log in before you can comment on or make changes to this bug.