Closed Bug 1519240 Opened 5 years ago Closed 5 years ago

Markdown comments ruin links wrapped in <>

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ehsan.akhgari, Assigned: dylan)

References

Details

Attachments

(1 file)

I don't know if I'm the only one doing this or not, but there are a lot of links on Bugzilla which are wrapped in <> in order to ensure they aren't broken into lines etc. When the comment in markdown'ed, the greater-than sign is appended to the URL, which makes them point to an invalid location.

Here is an example I was struggling with just now: https://bugzilla.mozilla.org/show_bug.cgi?id=1514340#c2

This is a regression caused by us allowing literal <html> tags to work.
cmark-gfm itself handles <https://searchfox.org/mozilla-central/rev/76fe4bb385348d3f45bbebcf69ba8c7283dfcec7/mobile/android/base/java/org/mozilla/gecko/toolbar/SecurityModeUtil.java#101> properly

Assignee: nobody → dylan
Depends on: 1518350
Attached file GitHub Pull Request

Sub-optimal solution here, but good enough until we can try pitching our "allow literal html tags" to upstream libcmark-gfm

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Thanks so much for the fix. :-)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: