15193 - Patch: New GD Perl module will not produce .GIF charts.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Mark Hamby]

The newest GD Perl module (via which Bugzilla creates charts)
no longer creates GIF files.  It creates PNG files instead.

To solve this problem, I had to patch both Bugzilla and the
Chart 0.99b Perl module.  The Bugzilla patch was trivial:
Replace every occurance of 'gif' with 'png' in reports.cgi.

The patch for the Chart Perl module is the same.  Replace every
instance of 'gif' with 'png'.  Then re-make and install.

I am also including a patch Holger Schurig submitted on the mailing
list that keeps Bugzilla from crashing when charts do not work.
I have not verified that the patch works.

Comment 1

[Mark Hamby]

Attachment: Patch to keep Bugzilla from crashing on charts.

Comment 2

[Brandon Black]

*** Bug 24231 has been marked as a duplicate of this bug. ***

Comment 3

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 4

[Mark Hamby]

This bug continues to be a problem for people installing Bugzilla
with new versions of GD.  It is a VERY QUICK FIX:
Replace all instances of 'gif' with 'png' in reports.cgi.

Mark

Comment 5

[Tara Hernandez]

picture time

Comment 6

[Don McCasland]

the Chart perl module has already been updated on CPAN to 0.99c-pre3
and uses pngs.  I've made a patch to reports.cgi to use either png
or gif depending on whether you have png support in your GD perl module.
So, the version you need:
Chart 0.99c-pre3
GD 1.23
libgd and libgd-devel 1.73

I need to now go find all the rest of the webtool dependancies on this and bring
them up to speed.

Comment 7

[GavinS]

Using:
Chart-0.99c-pre3
GD 1.27
bugzilla 2.10 (i.e with the png/gif detection bit in it)

I got the following actually appearing in place of the graph:

>> Software error:
>> 
>>          Can't locate object method "gif" via package "Chart::Lines" at 
>> /opt/bugzilla/reports.cgi line 510. 
>> 
>>                                         Please send mail to this site's 
>> webmaster for help. 

So I just set the type to png explicitly, like I did for bugzilla 2.8

The check for whether gif is a valid type doesn't seem to work :(
(for me, anyway)

Comment 8

[Mark Hamby]

I replaced my original patch with Don McCasland's fix and it worked just fine
for me.

Comment 9

[Matthew Tuck [:CodeMachine]]

Has the patch that "prevents bugzilla from crashing" or equivalent been applied?

Comment 10

[leger]

[e-mail]  - can you mark Verified now?  ok for you?

Comment 11

[Dave Miller [:justdave]]

Moving to Bugzilla product