1519302 - [BinAST] Add a pref to restrict BinAST file support to specific host

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Tooru Fujisawa [:arai]]

for early test, having a pref to restrict BinAST support to specific domain should reduce the attack surface.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1519302 - Add pref to restrict BinAST feature to specific hosts. r?baku

To reduce the attack surface in early test for BinAST, add a preference to
restrict the hosts that Firefox accepts BinAST file from.
The preference is turned on by default (BinAST itself is turned off by
default for now), and the list contains hosts which is going to be used in
early test.
For hosts not listed in the list, Firefox doesn't send BinAST MIME-Type in
Accept field, and doesn't handle BinAST file in case the server returns
BinAST file.

Comment 2

[Tooru Fujisawa [:arai]]

I updated the hosts list in all.js, can you review that part?
(I'm not sure how I can ask review again there)

Comment 3

[Andrea Marchesini [:baku]]

Done. See my comments in phabricator.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c88a33dc39f
Add pref to restrict BinAST feature to specific hosts. r=baku

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing _mozilla/binast/domain-restrict-excluded.https.html

Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=222238383&revision=d50d152c74c71a2581ecfb373f9efb8255aef4a2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222238383&repo=autoland&lineNumber=7975

Backout: https://hg.mozilla.org/integration/autoland/rev/7c002ce6b6cc022166693ea200de66dc2ca7b811

Comment 6

[Tooru Fujisawa [:arai]]

forgot that tests that don't execute BinAST files pass even we don't enable it.
will fix shortly.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/671054606438
Add pref to restrict BinAST feature to specific hosts. r=baku

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/671054606438

Comment 9

[Intermittent Failures Robot]

1 failures in 2378 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1519302&startday=2019-01-14&endday=2019-01-20&tree=all