Closed Bug 1519312 Opened 1 year ago Closed 1 year ago

Render the console input to the left of the panel when `devtools.webconsole.input.editor` is true

Categories

(DevTools :: Console, task, P1)

65 Branch
task

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [console-editor-mvp])

Attachments

(1 file)

No description provided.
Priority: -- → P2
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

When the editor preference is true, a CSS class is added to
the panel that allow us to shift the layout to a CSS Grid, where
the input panel is on the left and the output on the right.

A toolbar is added to be able to execute an expression when in
editor mode.

Depends on D17094

Attachment #9037899 - Attachment description: Bug 1519312 - Render the console input to the left of the panel when editor preference is true; . → Bug 1519312 - Render the console input to the left of the panel when editor preference is true; r=Honza.

Hi Nicolas! I'm new to the Mozilla scene and I am interested in fixing my first bug. Although this project is not labelled as a good-first-bug would this bug be appropriate for a beginner? Alternatively if there are other good first bugs you would recommend I'd love to get involved. Thanks!

Hello George,

As you can see in the header of this bug, it is already assigned (to me :) ).
You can have a look at the patch to see if you find it complex or not https://phabricator.services.mozilla.com//D17096

If you want, you can work on Bug 1519315 which should be a bit easier.

Honza, could you review the patch on this bug (it should only display the input to the left, no Enter changes, no gutter, … it's only a first layout patch that we will build things on top of).

Flags: needinfo?(odvarko)

In the meantime George, you can check http://docs.firefox-dev.tools/getting-started/ to setup the work environment, which takes a bit of time.
If you have any question, you can join our Slack (there's a #console channel).

Attachment #9037899 - Attachment is obsolete: true
Type: defect → enhancement

(needinfo no longer needed)

Flags: needinfo?(odvarko)
Type: enhancement → task
Blocks: 1554877
Priority: P2 → P1
Whiteboard: [console-editor-mvp]
Attachment #9037899 - Attachment is obsolete: false
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adf05ab240a5
Render the console input to the left of the panel when editor preference is true; r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.