Do not clear the console input when evaluating and `devtools.webconsole.input.editor` is true
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: u634192, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [console-editor-mvp])
Attachments
(1 file, 1 obsolete file)
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
Depends on D17096
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Hello Sola! I assigned you another bug I think, so maybe we should wait until you have that one done before taking a new one?
Reporter | ||
Comment 5•5 years ago
|
||
Hello Sola,
The bug is already assigned to you :)
There might be some overlap with Bug 1519315, so you can read the comments there, especially the ones that are about getting the preference value on the JsTerm component.
Again, don't hesitate to ask any questions, either here or on Slack :)
Hey Nicolas,
I have a couple of questions.
So we need to pass the editorMode prop from the App component to the JSTerm component, and then add in the check for clearing console input?
My local JSTerm file has a this._setValue("") on line 595, is that the same as this.setInputValue("") in D17097 (line 557 left side)?
All this seems dependent on revision D17096, should I wait until that is pushed before proceeding?
Reporter | ||
Comment 7•5 years ago
|
||
My local JSTerm file has a this._setValue("") on line 595, is that the same as this.setInputValue("") in D17097 (line 557 left side)?
Yes, it was renamed last week.
All this seems dependent on revision D17096, should I wait until that is pushed before proceeding?
You can try to have one commit that gets the editorMode
prop to the JsTerm, isolated. Then have another one for this specific bug (not clearing the input).
Then, we'll see who's the first to be ready to push the piping of editorMode
, and this will be the one that land it. Others would then need to rebase on that. So I think for now you can work on it, try to make it work, when it work, try to write a test, then we'll discuss again, depending of the status of the other patches on the same area :)
Updated•5 years ago
|
Create an editorMode
prop that is initialized with the preference value, and passed to the JSTerm component.
The prop is then used to check if the input should be cleared when an evaluation is done.
A test is added to ensure this works as expected.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90de1c90ae69 Do not clear the console input when evaluating and 'devtools.webconsole.input.editor' is true. r=nchevobbe
Comment 10•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•