1519345 - [uk] Fluent: Move localizations from Variants to Macros

Status: RESOLVED FIXED

(Mozilla Localizations :: uk / Ukrainian, enhancement)

Description

[Francesco Lodolo [:flod]]

With Fluent Syntax 0.8 Variants are deprecated and we need to migrate these translations to macros.

This task is going to be managed by l10n-drivers directly, please don't make changes for now. We're currently testing the infrastructure with Italian, and we'll take care of the changes in the coming days.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Move translations from Variants to Macros

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 9035904 [details] [diff] [review]
Move translations from Variants to Macros

Review of attachment 9035904 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/browser/branding/sync-brand.ftl
@@ +7,2 @@
>         *[nom] Синхронізація
>          [nom-lower] синхронізація

I think a better way to define this would be to nest select expressions:

    -sync-brand-short-name = { $case->
       *[nom] { $capitalization ->
           *[upper] Синхронізація
            [lower] синхронізація
        }
        [gen] { $first-letter ->
           *[upper] Синхронізації
            [lower] синхронізації
        }
        [dat] { $first-letter ->
           *[upper] Синхронізації
            [lower] синхронізації
        }
        [acc] { $first-letter ->
           *[upper] Синхронізацію
            [lower] синхронізацію
        }
        [abl] { $first-letter ->
           *[upper] Синхронізацією
            [lower] синхронізацією
        }
    }

You can then use multiple parameters when referencing the term:

    { -sync-brand-short-name(case: "abl", capitalization: "lower") }

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Move translations from Variants to Macros

Nested selects makes a lot more sense (also, there's only one usage of lower capitalization).

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 9035912 [details] [diff] [review]
Move translations from Variants to Macros

Review of attachment 9035912 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, thanks!

Comment 5

[Francesco Lodolo [:flod]]

https://hg.mozilla.org/l10n-central/uk/rev/17a29d1a796fb40358edca32047c27d96b23e7e5