1519347 - meta_filter not being used when loading manifest

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

When we switched to downloading the manifest we rather unfortunately broke the optimisation that we'd only load the parts of the manifest matching the meta_filter. There seem to be two issues here:

• We don't pass the meta_filter argument through load_and_update
• Updating a manifest with a meta_filter applied doesn't work because all the tests that don't match the filter are considered to be "new"

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1519347 - Fix passing meta_filters through wpt manifest update,

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Did this ever land?

Comment 3

[James Graham [:jgraham]]

Attachment: Bug 1519347 - Fix filtering jsshell tests,

The previous approach based on filtering the JSON data directly has a
number of problems that need more work to resolve, and the upstream
change to cache the manifest between update and usage has made these
problems blockers. In order to get things updated again, use the
construted ManifestItem objects as the basis for filtering. This is a
deoptimistation since it requires constructing a bunch of objects, but
it's at least working.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c983e907bbfd
Fix filtering jsshell tests, r=Ms2ger

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c983e907bbfd

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15314 for changes under testing/web-platform/tests