Closed Bug 1519347 Opened 11 months ago Closed 10 months ago

meta_filter not being used when loading manifest

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

References

Details

Attachments

(2 files)

When we switched to downloading the manifest we rather unfortunately broke the optimisation that we'd only load the parts of the manifest matching the meta_filter. There seem to be two issues here:

  • We don't pass the meta_filter argument through load_and_update
  • Updating a manifest with a meta_filter applied doesn't work because all the tests that don't match the filter are considered to be "new"

Did this ever land?

Assignee: nobody → james
Flags: needinfo?(james)

The previous approach based on filtering the JSON data directly has a
number of problems that need more work to resolve, and the upstream
change to cache the manifest between update and usage has made these
problems blockers. In order to get things updated again, use the
construted ManifestItem objects as the basis for filtering. This is a
deoptimistation since it requires constructing a bunch of objects, but
it's at least working.

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15314 for changes under testing/web-platform/tests
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.