Closed
Bug 1519397
Opened 5 years ago
Closed 5 years ago
Factor RAII locking classes out of Runtime.h
Categories
(Core :: JavaScript: GC, enhancement, P5)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
8.91 KB,
patch
|
pbone
:
review+
|
Details | Diff | Splinter Review |
At the moment AutoLockGC and associated classes are defined in vm/Runtime.h despite being mainly used internally by the GC.
Assignee | ||
Comment 1•5 years ago
|
||
Ideally these could live in GCRuntime.h but the constructors take a JSRuntime* but that has not been defined this that point. For now move them to their own header.
Attachment #9035918 -
Flags: review?(pbone)
Comment 2•5 years ago
|
||
Comment on attachment 9035918 [details] [diff] [review] bug1519397-auto-gc-lock Review of attachment 9035918 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks.
Attachment #9035918 -
Flags: review?(pbone) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1cebf4f5c850 Factor GC locking RAII classes out of vm/Runtime.h r=pbone
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b2c8d145541 Fix non-unified build bustage r=me
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1cebf4f5c850
https://hg.mozilla.org/mozilla-central/rev/2b2c8d145541
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•