Closed
Bug 1519405
Opened 5 years ago
Closed 5 years ago
Flags are passed to Zone::discardJitCode as bools
Categories
(Core :: JavaScript: GC, enhancement, P5)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
4.00 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
As a minor tidyup would could pass the flags specifying what to discard as enums rather than bools.
|
Assignee | |
Comment 1•5 years ago
|
||
Patch to replace these bools with enums.
Attachment #9035924 -
Flags: review?(jdemooij)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9035924 [details] [diff] [review] bug1519405-discard-flags Review of attachment 9035924 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this! Personally I really like (the type safety of) enum classes, but this is a clear improvement.
Attachment #9035924 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3588e0ddb99e Add enums for flags passed to Zone::discardJitCode() r=jandem
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•