Wikipedia searchplugin for zh-TW is broken
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox-esr60 unaffected, firefox64 wontfix, firefox65 fixed, firefox66 fixed)
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | wontfix |
firefox65 | --- | fixed |
firefox66 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by francesco.lodolo@mozillaitalia.org: https://hg.mozilla.org/integration/autoland/rev/fe5073e21dc5 Fix XML error in Wikipedia searchplugin for zh-TW r=mkaply
Comment 3•5 years ago
|
||
bugherder |
Assignee | ||
Comment 4•5 years ago
|
||
Reminder to verify this and request uplift.
Assignee | ||
Comment 5•5 years ago
|
||
Verified on 66.0a1 (2019-01-12) (64 bit)
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9035945 [details]
Bug 1519428 - Fix XML error in Wikipedia searchplugin for zh-TW
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: None
User impact if declined: Wikipedia searchplugin not available when zh-TW is selected as language
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Only affecting one searchplugin for one locale
String changes made/needed: None
Assignee | ||
Comment 7•5 years ago
|
||
For the record, I actually caused this in bug 1457376.
https://hg.mozilla.org/mozilla-central/diff/b429d98cdb06/mobile/locales/searchplugins/wikipedia-zh-TW.xml
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Comment on attachment 9035945 [details]
Bug 1519428 - Fix XML error in Wikipedia searchplugin for zh-TW
[Triage Comment]
Fixes the Wikipedia search plugin not being available when zh-TW is the selected language. Approved for 65.0b11.
Comment 9•5 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Description
•