Make CleanupPreviousVersionRegKeys() configurable via config.ini

VERIFIED FIXED

Status

SeaMonkey
Installer
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: dprice (gone), Assigned: dprice (gone))

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2 rtm] [ETA 06/24])

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

16 years ago
In the netscape side of things we have registry keys under
HKLM\Software\Netscape\Netscape and HKLM\Software\Netscape\Netscape 6 

The current CleanupPreviousVersionRegKeys() is stomping on some of our newly
made keys in the Netscape 6 key because the Netscape\Netscape 6\Current version
is 6.x not 7. (that is a valid value for cases where people have side by side
installs)  

To make this flexable, we want to create a section in config.ini that looks like
this:

[Cleanup Previous Product RegKeys]
Reg Key Root=HKEY_LOCAL_MACHINE
Product Name0=Netscape
Product Reg Key0=Software\Netscape\Netscape
Current Version0=7.0b1 (en)
Product Name1=Netscape 6
Product Reg Key1=Software\Netscape\Netscape 6
Current Version1=7.0b1 (en)


see http://bugscape.netscape.com/show_bug.cgi?id=14631 for full details
(Assignee)

Comment 1

16 years ago
Created attachment 87750 [details] [diff] [review]
patch to the installer
(Assignee)

Comment 2

16 years ago
Created attachment 87751 [details] [diff] [review]
context diff

a context diff may be easier to read.
(Assignee)

Updated

16 years ago
Keywords: nsbeta1
(Assignee)

Comment 3

16 years ago
Created attachment 87760 [details] [diff] [review]
patch 1 - changes to config.it
(Assignee)

Comment 4

16 years ago
Let's make it a little more flexable so one can delete keys in different roots

This example will clean up in HKLM and HKCU

[Cleanup Previous Product RegKeys]
Reg Key Root0=HKEY_LOCAL_MACHINE
Product Name0=Mozilla
Product Reg Key0=Software\Mozilla.org\Mozilla
Current Version0=1.1 (en)
Reg Key Root1=HKEY_CURRENT_USER
Product Name0=Mozilla
Product Reg Key0=Software\Mozilla.org\Mozilla
Current Version0=1.1 (en)
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt2 rtm
(Assignee)

Updated

16 years ago
Whiteboard: [adt2 rtm → [adt2 rtm]

Updated

16 years ago
QA Contact: bugzilla → ktrina

Comment 5

16 years ago
Comment on attachment 87760 [details] [diff] [review]
patch 1 - changes to config.it

r=curt
Attachment #87760 - Flags: review+

Comment 6

16 years ago
Comment on attachment 87750 [details] [diff] [review]
patch to the installer

r=curt
Attachment #87750 - Flags: review+
(Assignee)

Comment 7

16 years ago
Created attachment 88218 [details] [diff] [review]
patch 2
Attachment #87750 - Attachment is obsolete: true
Attachment #87751 - Attachment is obsolete: true
(Assignee)

Comment 8

16 years ago
Created attachment 88219 [details] [diff] [review]
patch 2 - config changes
Attachment #87760 - Attachment is obsolete: true

Comment 9

16 years ago
Comment on attachment 88218 [details] [diff] [review]
patch 2

r=curt
Attachment #88218 - Flags: review+

Comment 10

16 years ago
Comment on attachment 88219 [details] [diff] [review]
patch 2 - config changes

r=curt
Attachment #88219 - Flags: review+
Attachment #88219 - Flags: superreview+
Comment on attachment 88219 [details] [diff] [review]
patch 2 - config changes

sr=dveditz

mozilla.org is all lowercase
(Assignee)

Comment 12

16 years ago
Created attachment 88239 [details] [diff] [review]
patch 3
Attachment #88218 - Attachment is obsolete: true

Updated

16 years ago
Keywords: approval, mozilla1.0.1
Whiteboard: [adt2 rtm] → [adt2 rtm] [ETA 06/24]
Comment on attachment 88239 [details] [diff] [review]
patch 3

sr=dveditz
Attachment #88239 - Flags: superreview+
(Assignee)

Comment 14

16 years ago
on the trunk
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Keywords: adt1.0.1
Resolution: --- → FIXED

Comment 15

16 years ago
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.
Blocks: 143047
Keywords: adt1.0.1 → adt1.0.1+

Updated

16 years ago
Attachment #88239 - Flags: approval+

Comment 16

16 years ago
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
(Assignee)

Comment 17

16 years ago
on the branch
Keywords: mozilla1.0.1+ → fixed1.0.1

Comment 18

16 years ago
verified
trunk 2002070308, branch 2002070308
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.1 → verified1.0.1
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.