151954 - Incorrect check of PR_Malloc failure in nsMsgHeaderParser::ReformatUnquotedAddresses

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[David Bradley]

Ran across this in a Purify run. The test below is incorrect. The main danger is
that it can give out of memory errors erroneously.

  char * outputStr = (char *) PR_Malloc(outputMaxLen);
  if (!*outputStr)
    return NS_ERROR_OUT_OF_MEMORY;

Patch comming up.

Comment 1

[David Bradley]

Attachment: Patch to fix the test

Comment 2

[Jean-Francois Ducarroz]

oops! good catch...

Comment 3

[Jean-Francois Ducarroz]

Comment on attachment 87763 [details] [diff] [review]
Patch to fix the test

R=ducarroz

Comment 4

[David :Bienvenu]

Comment on attachment 87763 [details] [diff] [review]
Patch to fix the test

sr=bienvenu

Comment 5

[Jean-Francois Ducarroz]

Fix checked in the trunk

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

I read a message which contained multiple types of attachments, as well as 
sending myself a Python file and reading that message.

I'm not sure I've hit all the MIME cases, but as far as I can tell, this is 
fixed.

David, do you remember what error Purify threw?

Verified FIXED on the trunk, Windows 2000, unless I find this somehow.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

nominating - this _might_ help the mac OS 9/8.5 platforms, where memory
management is more fragile

Comment 8

[David Bradley]

The error was as follows: 
[W] UMR: Uninitialized memory read in
nsMsgHeaderParser::ReformatUnquotedAddresses(WORD const*,WORD * *) {1 occurrence}