Closed
Bug 1519563
Opened 7 years ago
Closed 7 years ago
Add missing include in WindowNamedPropertiesHandler.cpp
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | affected |
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
1.00 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
We get a compile error in TB due to this line:
https://searchfox.org/comm-central/rev/ab062df16f6764dfe7adad09a21fc84a4af732d0/mozilla/dom/base/WindowNamedPropertiesHandler.cpp#110
|
Assignee | |
Comment 1•7 years ago
|
||
One review will do.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9036054 -
Flags: review?(nika)
Attachment #9036054 -
Flags: review?(bzbarsky)
|
||
Updated•7 years ago
|
Attachment #9036054 -
Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/mozilla-central/rev/3aec75953c28
add missing include of WindowProxyHolder.h to WindowNamedPropertiesHandler.cpp. r+a=qdot
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 9036054 [details] [diff] [review]
1519563.patch
I asked on #sheriffs before pushing ;-)
Attachment #9036054 -
Flags: review?(nika)
Attachment #9036054 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #0)
We get a compile error in TB due to this line:
Uff, bad link, this is right:
https://searchfox.org/mozilla-central/rev/7adb490485eff0783071a3e132005bceeb337461/dom/base/WindowNamedPropertiesHandler.cpp#110
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•