Convert toolbarbutton bindings to custom elements

NEW
Unassigned

Status

()

enhancement
P3
normal
3 months ago
an hour ago

People

(Reporter: timdream, Unassigned)

Tracking

(Depends on 2 bugs, Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [xbl-available])

These bindings are ready to be converted to custom element. Its anonymous content can be prepended/appended when CE connects.

  • toolbarbutton
  • toolbarbutton.xml#menu
  • toolbarbutton-badged
  • toolbarbutton-badged-menu
  • button

They will inherit a button-base base class that may be implemented as a mixin. button-base will inherit basetext.

The use of display feature will need to be removed first.

Noted that the toolbarbutton.xml#menu binding is unrelated to menu.xml#menu, which is covered in bug 1519502.

raw note (note on menu is obsolete because of the fact above):

button-base
Already converted, but we need to remove all XBL inherited bindings before this can be removed. Bug can be filed to track dependency.
toolbarbutton
menu
See menu-base above. Could first move the menu selector from xul.css to menu-base binding, although it doesn’t cover the removal of this binding
toolbarbutton-badged
This uses <children> added in https://bugzilla.mozilla.org/show_bug.cgi?id=1419005, only for download toolbar button. May be able to move the caller?
https://searchfox.org/mozilla-central/rev/b4ebbe90ae4d0468fe6232bb4ce90699738c8125/browser/base/content/browser.xul#1088-1097
toolbarbutton-badged-menu https://bugzilla.mozilla.org/show_bug.cgi?id=1512993
button

Whiteboard: [xbl-available]
Depends on: 1538983
Summary: Convert button/toolbarbutton bindings to custom elements → Convert toolbarbutton bindings to custom elements
Depends on: 1546541
You need to log in before you can comment on or make changes to this bug.