1519598 - Add a mach command for processing contributor PRs

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

I thought about it and I think what we really want is a mach command that people can run when they want to land a contributor's PR to the webrender repo. The command would file a bug, import the patches and put them in phab, and also do a try push. Optional arguments can be used to control the behavior more precisely. Filing this bug so I don't forget.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1519598 - WIP

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Notes from discussion with :kvark:

• The script should accept a full PR URL instead of hard-coding servo/webrender stuff, so that it can be used for multiple repositories (WebGPU in particular), and then have a mapping from repository to m-c path where the patch applies
• The script should not require a bug number or API token; in which case it can just be submitted to phabricator without any bug number
• We can use a dummy bugzilla account (need to create one) to submit to phabricator so that staff can self-review volunteer patches without requiring an extra person to rubberstamp. We currently have the [e-mail] account that I've used to do this but it would be better to create one @mozilla.com that can be managed by other people too.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I updated the script to address the first two bullet points from the above comment.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1519598 - Add a commit function in the repository helper. r?ahal

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1519598 - Add a mach command to import PRs from github. r?kvark

This is a simple mach command that imports a PR from a whitelisted set
of github repositories into the local m-c clone. It works by downloading
the .patch file from github, splitting the different commits, and
applying those commits to the local repo via the patch tool and git/hg
commit. It optionally allows filing a bug or providing a bug number, and
specifying a reviewer.

This is one part of a larger workflow that facilitates landing
contributor patches into m-c when those patches are submitted as PRs.
Other components of the workflow (to be added in the future) will make
it easier to actually test and land the patch.

Depends on D35205

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1d6f371446f
Add a commit function in the repository helper. r=ahal
https://hg.mozilla.org/integration/autoland/rev/72d858dcdb26
Add a mach command to import PRs from github. r=kvark,ahal

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e1d6f371446f
https://hg.mozilla.org/mozilla-central/rev/72d858dcdb26

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

My understanding is that nothing not built-in should be imported at the top level of mach_commands.py files, as mach imports them before it sets up the Python environment properly. I'm guessing in this case that it pulled in a requests hiding somewhere else on the system that had old certificates or none at all. And once that's in sys.modules, any later import requests will get the same thing.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Yes, the patch on bug 1561261 corrects that problem.